-
Notifications
You must be signed in to change notification settings - Fork 144
Add support for share targets image sharing #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @alabiaga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've implemented support for receiving and handling shared images from other applications. This change enables users to share images directly into a chat conversation within our app. The core functionality involves updating the app's manifest to declare image handling capabilities, extracting image URIs from incoming share intents, and then passing these URIs through the navigation system to prefill the chat input with the shared image.
Highlights
- Manifest Update for Image Sharing: I've updated the
AndroidManifest.xmlto declare the app's ability to receive shared image content, specifically forimage/*MIME types. This is crucial for the Android system to route image sharing intents to our application. - Image URI Extraction from Share Intents: I've modified
AppArgs.ktto extract image URIs from incomingACTION_SENDintents. TheShortcutParamsnow includes amediaUrifield, ensuring that shared image data is captured and passed along when the app is launched via a share target. - Image URI Propagation to Chat Screen: I've extended the
ChatThreadpane inSocialiteNavigation.ktand updatedMain.ktandChatScreen.ktto propagate theprefilledImageUri. This allows theChatScreento receive and process an image URI directly upon navigation. - Image Prefilling in Chat ViewModel: I've added a
prefillInputImagefunction toChatViewModel.kt. This function handles the incoming image URI by attaching it as aMediaItemto the chat input, making the shared image ready for sending within the chat. - Share Target Configuration for Images: I've added a new
share-targetentry insharing_shortcuts.xmlspecifically forimage/*MIME types. This ensures that when an image is shared from another app, ourMainActivityis registered as a valid target.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for receiving shared images. The changes correctly update the AndroidManifest, navigation components, and the chat screen to handle incoming image URIs. However, there are some critical issues in AppArgs.kt related to null safety and the logic for handling share intents. These issues could lead to application crashes or prevent the feature from working in common scenarios, such as sharing an image without text. I've provided detailed comments and suggestions to address these problems.
Handle receiving images
e.g.
https://developer.android.com/training/sharing/receive#handling-content