Skip to content

Conversation

@alabiaga
Copy link
Member

@alabiaga alabiaga commented Aug 8, 2025

@alabiaga alabiaga requested a review from ashnohe August 8, 2025 03:35
@alabiaga alabiaga self-assigned this Aug 8, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @alabiaga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've implemented support for receiving and handling shared images from other applications. This change enables users to share images directly into a chat conversation within our app. The core functionality involves updating the app's manifest to declare image handling capabilities, extracting image URIs from incoming share intents, and then passing these URIs through the navigation system to prefill the chat input with the shared image.

Highlights

  • Manifest Update for Image Sharing: I've updated the AndroidManifest.xml to declare the app's ability to receive shared image content, specifically for image/* MIME types. This is crucial for the Android system to route image sharing intents to our application.
  • Image URI Extraction from Share Intents: I've modified AppArgs.kt to extract image URIs from incoming ACTION_SEND intents. The ShortcutParams now includes a mediaUri field, ensuring that shared image data is captured and passed along when the app is launched via a share target.
  • Image URI Propagation to Chat Screen: I've extended the ChatThread pane in SocialiteNavigation.kt and updated Main.kt and ChatScreen.kt to propagate the prefilledImageUri. This allows the ChatScreen to receive and process an image URI directly upon navigation.
  • Image Prefilling in Chat ViewModel: I've added a prefillInputImage function to ChatViewModel.kt. This function handles the incoming image URI by attaching it as a MediaItem to the chat input, making the shared image ready for sending within the chat.
  • Share Target Configuration for Images: I've added a new share-target entry in sharing_shortcuts.xml specifically for image/* MIME types. This ensures that when an image is shared from another app, our MainActivity is registered as a valid target.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for receiving shared images. The changes correctly update the AndroidManifest, navigation components, and the chat screen to handle incoming image URIs. However, there are some critical issues in AppArgs.kt related to null safety and the logic for handling share intents. These issues could lead to application crashes or prevent the feature from working in common scenarios, such as sharing an image without text. I've provided detailed comments and suggestions to address these problems.

@alabiaga alabiaga merged commit f847577 into android:main Aug 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants