-
Notifications
You must be signed in to change notification settings - Fork 632
Update to the 1.4/1.6 releases of android.wear.{protolayout,tiles} #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ithinkihaveacat
wants to merge
8
commits into
android:main
Choose a base branch
from
ithinkihaveacat:tiles-1.6-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
eb192fd
Migrate to alpha
ithinkihaveacat bc26f51
Migrations
ithinkihaveacat c0de954
Fix preview
ithinkihaveacat 39a53c5
Merge remote-tracking branch 'origin/main' into migrate-to-alpha
ithinkihaveacat a785a6c
Update Wear Tiles to 1.6.0-beta01 and ProtoLayout to 1.4.0-beta01
ithinkihaveacat 6acc38d
Switch MessagingTileService to Material3TileService
ithinkihaveacat 4e1ec32
Migrate MessagingTileService to automated resource management
ithinkihaveacat e48be93
Upgrade Gradle, AGP, and Kotlin in WearTilesKotlin
ithinkihaveacat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
imageIdfrom theEventdata is being ignored here. Theletblock checks ifdata.imageIdis not null, but then a hardcoded drawableR.drawable.photo_38is used for the background image. This means the tile will always show the same background image regardless of theimageIdprovided in theEventdata.This seems to be due to an incomplete migration for this file. To fix this, you should update the
Eventdata class to use anInt?forimageIdinstead ofString?, and update its call sites. This is the pattern used in other files in this PR, likeMedia.kt.After updating the data class, this block should be changed to use the
imageIdfrom the data, for example: