Update to navigation 3 and update padding#1363
Open
kul3r4 wants to merge 2 commits intoandroid:mainfrom
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the application from the legacy Wear Compose Navigation library to Navigation 3 and replaces Horologist's responsive padding utilities with standard Material 3 vertical content padding. Key changes include the implementation of type-safe navigation using Kotlin serialization and the transition to NavDisplay for screen management. The review feedback highlights opportunities to optimize performance by wrapping the entryProvider in remember and suggests cleaning up stale documentation links and comments that still reference the previous navigation and layout libraries.
...r/app/src/main/java/com/example/android/wearable/composestarter/presentation/MainActivity.kt
Outdated
Show resolved
Hide resolved
...r/app/src/main/java/com/example/android/wearable/composestarter/presentation/MainActivity.kt
Show resolved
Hide resolved
...r/app/src/main/java/com/example/android/wearable/composestarter/presentation/MainActivity.kt
Outdated
Show resolved
Hide resolved
kul3r4
requested review from
yschimke
and removed request for
garanj and
shumelchyk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies changes to use Compose 1.6 new features: