This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Making sure that loading it with webpack resolves to non-polyfill whe…#282
Open
activenode wants to merge 1 commit into
Open
Making sure that loading it with webpack resolves to non-polyfill whe…#282activenode wants to merge 1 commit into
activenode wants to merge 1 commit into
Conversation
…n native support Loading it with webpack would require additional checkings which are actually not required if we just return `global.Intl` as it is set to Polyfill anyway when no native support is given.
Author
|
Are you really sure that the given test is correct? Why should the Polyfill according to the Specs deliver something else than the Spec given one? |
Author
|
@andyearnshaw Can you please check this commit? |
Collaborator
|
This is a non-backward compatible change, but it might be fine for the next release. The reasoning here is how someone will get a handle on the polyfill if they want to, even if the env supports Intl? they can still do it by setting Intl to undefined, importing this, and grabbing the new global. Maybe we can just offer another file that can be required, to get the inner pieces. Will merge it before next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n native support
Loading it with webpack would require additional checkings which are actually not required if we just return
global.Intlas it is set to Polyfill anyway when no native support is given.