chore(release): register brepjs-voxel-wasm + boundary enforcement test#1238
Conversation
Wire brepjs-voxel-wasm into release-please (manifest entry + component) so the published package gets versioned, and exclude the experimental brepjs-voxel domain from the root brepjs package. Make the layer-boundary scan root overridable via BOUNDARY_SRC_DIR so the enforcement can be exercised against throwaway fixtures, and add negative tests proving upward imports (voxel L2 -> lattice/sketching L3, core L1 -> voxel L2) are actually rejected (ADR-0013 sec 9).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Benchmark Results
All benchmarks within tolerance. |
size-limit report 📦
|
Greptile SummaryThis PR wires up release-please CI plumbing for the
Confidence Score: 5/5Safe to merge — changes are narrowly scoped to CI config and a test harness with no impact on runtime code. All four changed files are either JSON config or non-runtime scripts/tests. The release-please additions follow the existing package pattern exactly. The shell script change is a minimal two-site substitution with correct variable quoting. The new test file exercises the real script against isolated temp fixtures and cleans up after itself reliably. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "chore(release): register brepjs-voxel-wa..." | Re-trigger Greptile |
What
Closes the release/CI plumbing gap for the voxel domain. The voxel packages already landed on
main, but their release-please wiring did not.brepjs-voxel-wasmas a release component (manifest entry at0.1.0+ config entry) so the published package gets versioned. Exclude the experimentalbrepjs-voxeldomain from the rootbrepjspackage so its changes don't bump the library version.BOUNDARY_SRC_DIR(defaultsrc) so the enforcement script can run against throwaway fixtures, and add negative tests proving upward imports are actually rejected (ADR-0013 §9 — "add negative tests proving enforcement is live").Why
Without the release-please registration, the published
brepjs-voxel-wasmpackage wouldn't receive version bumps or releases. The boundary script previously only emitted a friendly "passed" line — a silent escape (e.g. a layer dir missing fromget_layer) would pass unnoticed; the new tests guard against that.Notes
The boundary-script change was re-derived onto
main's currentrealpath --relative-to="$SRC_DIR"resolver (an earlier rewrite replaced the python3-normpathpath the original patch targeted). Only the literalsrc/strips were touched;main's resolver already honored$SRC_DIR.Test plan
bash scripts/check-layer-boundaries.shpasses against realsrc/npx vitest run tests/layerBoundaries.test.ts— 7/7 (4 forbidden-import rejections, 3 allowed-import passes)test:ci+knippassed