test: raise the 100k deep-cascade timeout to 60s (CI flake under load)#90
Merged
Conversation
The recursion-free deep-cascade test builds a 100k-link chain (100k spawn + addPair) before despawning — ~8s locally, but it can exceed the 30s timeout on a heavily contended CI runner, producing spurious failures unrelated to the code under test. Bump to 60s (7.5x the local time) for headroom; the assertion and the decisive DEPTH=100k are unchanged.
Greptile SummaryBumps the timeout on the
Confidence Score: 5/5Safe to merge — this is a one-line timeout increase with no changes to test logic or application code. The change is narrowly scoped: one timeout value in one test, with all assertions, constants, and cascade logic left intact. There is no risk of masking real slowness at 60 s given that the test runs in ~8 s locally. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "test: raise the 100k deep-cascade timeou..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recursion-free deep-cascade test (
m8-relations.property.test.ts) builds a 100k-link chain before despawning — ~8s locally, but it overran the 30s timeout on a contended CI runner and spuriously failed a docs PR. Bump to 60s (7.5× the local time); the assertion and the decisiveDEPTH=100000are unchanged. Pure CI-robustness fix.