Let andy_tandem_dev4 compile#209
Open
jwoglom wants to merge 3 commits intoandyrozman:andy_tandem_dev4from
Open
Let andy_tandem_dev4 compile#209jwoglom wants to merge 3 commits intoandyrozman:andy_tandem_dev4from
jwoglom wants to merge 3 commits intoandyrozman:andy_tandem_dev4from
Conversation
1. TandemPairingManager.kt — Replaced .setCustomTitle(AlertDialogHelper.buildCustomTitle(...)) with .setTitle()
2. TandemUICommunication.kt — Added NotificationManager to constructor, replaced uiInteraction.addNotification(Notification.*) with notificationManager.post(NotificationId.*, NotificationLevel.*)
3. TandemPumpConnector.kt — Changed sendBasalProfile(profile: PumpProfile) to sendBasalProfile(profile: Profile), replaced profile.dia with profile.iCfg?.dia
4. ActionsActivity.kt — Changed base class from DaggerComponentActivity to DaggerAppCompatActivity, removed ComposeUiProvider injection pattern, added notificationManager for TandemUICommunication constructor
5. DataActivity.kt — Same changes as ActionsActivity
6. TandemModule.kt — Removed TandemComposeUiComponent subcomponent, uncommented @ContributesAndroidInjector for both activities
7. TandemMobiPumpPlugin.kt — Wrapped 5 PumpSync calls in runBlocking {}
8. TandemMobiPumpFragment.kt — Removed EventExtendedBolusChange and EventTempBasalChange imports and subscriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.