feat(deploy): allow overriding compute plane configuration via action inputs - #30
Merged
Merged
Conversation
lemaitre-aneo
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When deploying ArmoniK, the compute plane configuration (worker image, version, partition, socket type) is typically derived from existing Terraform variables. However, in some scenarios — such as CI testing or custom deployments — callers need to override the compute plane with a specific worker configuration without modifying tfvars files manually.
Description
Adds five new optional inputs to the
deployaction:override-compute(default:false): feature flag to enable compute plane overrideoverride-worker-version(default:latest): worker image tagoverride-worker-partition(default:default): partition nameoverride-worker-image(default:dockerhubaneo/armonik_worker_dll): worker imageoverride-worker-socket(default:unixdomainsocket): socket typeWhen
override-computeistrue, acompute_plane()shell function rewrites thecompute_planesection ofextra.tfvars.jsonusingjq, setting a single partition with sensible resource limits and a Prometheus-based HPA.Testing
override-compute: trueand the worker inputs in a workflow, then confirming the generatedextra.tfvars.jsoncontains the expectedcompute_planeblock.Impact
override-computedefaults tofalse, so existing workflows are unaffected.Additional Information
The HPA configuration written by the override uses fixed values (min 0, max 5 replicas, Prometheus trigger threshold 2). If more flexibility is needed in the future, additional inputs can be introduced.