Skip to content

feat(deploy): allow overriding compute plane configuration via action inputs - #30

Merged
aneojgurhem merged 1 commit into
mainfrom
jg/overridecompute
Apr 29, 2026
Merged

aneojgurhem merged 1 commit into
mainfrom
jg/overridecompute

Conversation

@aneojgurhem

@aneojgurhem aneojgurhem commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Motivation

When deploying ArmoniK, the compute plane configuration (worker image, version, partition, socket type) is typically derived from existing Terraform variables. However, in some scenarios — such as CI testing or custom deployments — callers need to override the compute plane with a specific worker configuration without modifying tfvars files manually.

Description

Adds five new optional inputs to the deploy action:

  • override-compute (default: false): feature flag to enable compute plane override
  • override-worker-version (default: latest): worker image tag
  • override-worker-partition (default: default): partition name
  • override-worker-image (default: dockerhubaneo/armonik_worker_dll): worker image
  • override-worker-socket (default: unixdomainsocket): socket type

When override-compute is true, a compute_plane() shell function rewrites the compute_plane section of extra.tfvars.json using jq, setting a single partition with sensible resource limits and a Prometheus-based HPA.

Testing

  • No automated tests added (shell logic within a GitHub Actions composite action).
  • Manually verify by setting override-compute: true and the worker inputs in a workflow, then confirming the generated extra.tfvars.json contains the expected compute_plane block.

Impact

  • No breaking changes; all new inputs are optional with safe defaults.
  • override-compute defaults to false, so existing workflows are unaffected.

Additional Information

The HPA configuration written by the override uses fixed values (min 0, max 5 replicas, Prometheus trigger threshold 2). If more flexibility is needed in the future, additional inputs can be introduced.

@CLAassistant

CLAassistant commented Apr 29, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@aneojgurhem
aneojgurhem merged commit 4e5c5c1 into main Apr 29, 2026
2 checks passed
@aneojgurhem
aneojgurhem deleted the jg/overridecompute branch April 29, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants