feat: Add module to get a Key from the GCP Project - #84
hbitoun-aneo wants to merge 10 commits into
Conversation
lemaitre-aneo
left a comment
There was a problem hiding this comment.
This module should behave similarly than the kms module (except for resource creation). In particular, it should support multiple keys per key ring, and have the same output as the kms module.
There was a problem hiding this comment.
The documentation should highlight the purpose of the module in the framework of ArmoniK
lemaitre-aneo
left a comment
There was a problem hiding this comment.
I am not a big fan of the name of the module. I would prefer to have kms at the beginning of the name.
Here are some name suggestions (in order of personal preference):
kms-getkms-datakms-existingkms-importkms-external
| type = string | ||
| variable "crypto_key_names" { | ||
| description = "The names of the crypto keys to retrieve from the GCP project." | ||
| type = list(string) |
There was a problem hiding this comment.
| type = list(string) | |
| type = set(string) |
| @@ -1,4 +1,19 @@ | |||
| output "my_crypto_key_output" { | |||
There was a problem hiding this comment.
| output "my_crypto_key_output" { | |
| output "cyprto_keys" { |
There was a problem hiding this comment.
There is a missing output compared to to the resource module:
output "crypto_key_ids" {
description = "The Map of the created crypto keys."
value = { for key, value in google_kms_crypto_key.keys : key => value.id }
}|
|
No description provided.