Skip to content

feat: bench gcp side - #1361

Open
mkgharbi-aneo wants to merge 12 commits into
mainfrom
mkg/bench-gcp
Open

mkgharbi-aneo wants to merge 12 commits into
mainfrom
mkg/bench-gcp

Conversation

@mkgharbi-aneo

Copy link
Copy Markdown
Contributor

Motivation

Related to ArmoniK benchmarking automation project, the suitable GCP architecture and fixed versions that are used in the session.

Description

A fixed-versionned architecture of GCP deployment of Armonik with a throughput equals approximately at 2200 tasks/s.

Testing

This workflow runs on every push on the PR's branch.

Impact

This PR implements a milestone for ArmoniK benchmarking capacity, as AK would be benchmarked frequently.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@mkgharbi-aneo mkgharbi-aneo added the Enhancement New feature or request label Jan 29, 2025
@mkgharbi-aneo mkgharbi-aneo self-assigned this Jan 29, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to add some lines in the job define-matrix of bench-benchmark.yaml, much less code duplication and would have to run bench on localhost twice

Comment thread benchmarking/gcp/versions.tfvars.json Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to have this file in a subfolder how it done here : https://github.com/aneoconsulting/ArmoniK/tree/main/benchmarking/aws

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it dated with the commit hash ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it's armonik version + hash. Can you refactor your work to do something similar please ?

@mkgharbi-aneo
mkgharbi-aneo force-pushed the mkg/bench-gcp branch 13 times, most recently from 5d8161f to c2333e0 Compare February 4, 2025 10:22
@sonarqubecloud

sonarqubecloud Bot commented Feb 4, 2025

Copy link
Copy Markdown

@mkgharbi-aneo
mkgharbi-aneo force-pushed the mkg/bench-gcp branch 2 times, most recently from f71da0b to e1aa19f Compare July 4, 2025 14:03
@lemaitre-aneo
lemaitre-aneo changed the base branch from main to fl/bench-improv July 4, 2025 14:23
@sonarqubecloud

sonarqubecloud Bot commented Jul 4, 2025

Copy link
Copy Markdown

Base automatically changed from fl/bench-improv to main July 7, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants