ci: refactor mcpauth CI job - #1444
Open
tschneider-aneo wants to merge 2 commits into
Open
tschneider-aneo wants to merge 2 commits into
tschneider-aneo wants to merge 2 commits into
Conversation
tschneider-aneo
force-pushed
the
ts/refactor-mcpauth
branch
3 times, most recently
from
March 5, 2026 12:51
82dbdc6 to
f28c2a1
Compare
7 tasks
tschneider-aneo
force-pushed
the
ts/refactor-mcpauth
branch
from
March 5, 2026 17:20
a5d8725 to
8390d08
Compare
tschneider-aneo
marked this pull request as ready for review
March 5, 2026 17:27
tschneider-aneo
marked this pull request as draft
March 5, 2026 17:29
tschneider-aneo
changed the title
tschneider-aneo
changed the title
tschneider-aneo
marked this pull request as ready for review
March 12, 2026 09:30
lemaitre-aneo
added a commit
to aneoconsulting/ArmoniK.Infra
that referenced
this pull request
Mar 13, 2026
# Motivation While developing [this PR](aneoconsulting/ArmoniK#1444), we faced an uncapacity to customly define a custom, yet needed, `loadbalancer` user when authentication is required but client certificates generation disabled. # Description Rearranges logic behind client certificates generation : - moves the term "default" to "builtin" - checks if builtin users are overrided in user-provided authentication data before asking ingress module to generate certs for them - merges the built-in users authentication data with user-provided ones, with predecence for the latter. # Testing Current branch-version passes CI in the bug-revealing [PR](aneoconsulting/ArmoniK#1444) # Impact More flexibility for AK authentication data initiation.
tschneider-aneo
force-pushed
the
ts/refactor-mcpauth
branch
2 times, most recently
from
March 19, 2026 09:58
09af606 to
c9c1f96
Compare
tschneider-aneo
force-pushed
the
ts/refactor-mcpauth
branch
from
March 19, 2026 12:44
c9c1f96 to
ba62efd
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Following #1440, ArmoniK now has an standard deployment for its load balancer. Given that, keeping an ad-hoc docker compose for deploying it in the CI would much less relevant.
Description
CI jobs (especially
mcpAuth) are now able to deploy ArmoniK with the Load Balancer.A new job named
auth, which is basicaly the same asmcpAuthexcept that it deploys a "classical" ArmoniK (i.e. without its load balancer) is added to CI.Pytest script that runs in the CI is made agnostic about whether AK's load balancer is deployed.
Certificate for user
armonik.mcpis ni longer generated since Load Balancer authentication data is hardcoded inside armonik TF moduleTesting
See CI validations in present PR.
Impact
Authentication and authorization logics are tested against standard ArmoniK deployments.
Additional Information
/
Checklist