This repository was archived by the owner on Feb 26, 2024. It is now read-only.
WIP: test for performance tuning of event invoke#1211
Open
JiaLiPassion wants to merge 2 commits intoangular:masterfrom
Open
WIP: test for performance tuning of event invoke#1211JiaLiPassion wants to merge 2 commits intoangular:masterfrom
JiaLiPassion wants to merge 2 commits intoangular:masterfrom
Conversation
mhevery
reviewed
Apr 4, 2019
Contributor
mhevery
left a comment
mhevery
left a comment
There was a problem hiding this comment.
My concern with this approach is that this will change all applications wether or not they are Angular. This change is significant enough to break unrelated behavior with unpredictable results.
What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.