Conversation
Replaces the `model:composer`, `model:topic` and `model:site-setting` overrides with the granular model extension APIs: `showEventControls`, `canCreateEvent` and `topicListItemClasses` become `addModelGetter`, and the `allowsNone` override becomes the `site-setting-allows-none` value transformer. The transformer also fixes a latent bug: the original `allowsNone` had no `return` in its `else` branch, so it returned `undefined` for every other setting whenever an admin had the plugin enabled. The remaining `modifyClass` calls target components, controllers, routes and a service, which are out of scope for the model APIs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modifyClass("model:*", ...);is being deprecated so this PR replaces themodel:composer,model:topicandmodel:site-settingoverrides with the granular model extension APIs:showEventControls,canCreateEventandtopicListItemClassesbecomeaddModelGetter, and theallowsNoneoverride becomes thesite-setting-allows-nonevalue transformer.