Skip to content

Include the base url when downloading the video. - #31

Open
vasilake-v wants to merge 1 commit into
anijackich:masterfrom
vasilake-v:feature-include-base-url
Open

Include the base url when downloading the video.#31
vasilake-v wants to merge 1 commit into
anijackich:masterfrom
vasilake-v:feature-include-base-url

Conversation

@vasilake-v

Copy link
Copy Markdown

Related to issue #28

The downloaded url is a relative path and the base url is included in the BaseUrl , inside MPD file

Sorry for the quick&dirty changes. Please let me know where to adjust and I would do this as soon as i can

= OPTIONS ============================
1) 360p   2) 480p   3) 720p   4) 1080p
> Quality: 3
[*] 720p is selected
======================================

= DOWNLOADING =================
Video:   0%|          | [0/16]
Traceback (most recent call last):
  File "kinescope-dl.py", line 79, in <module>
  File "click/core.py", line 1157, in __call__
  File "click/core.py", line 1078, in main
  File "click/core.py", line 1434, in invoke
  File "click/core.py", line 783, in invoke
  File "kinescope-dl.py", line 70, in main
  File "kinescope/downloader.py", line 152, in download
  File "kinescope/downloader.py", line 119, in _fetch_segments
  File "kinescope/downloader.py", line 100, in _fetch_segment
  File "requests/sessions.py", line 602, in get
  File "requests/sessions.py", line 575, in request
  File "requests/sessions.py", line 486, in prepare_request
  File "requests/models.py", line 368, in prepare
  File "requests/models.py", line 439, in prepare_url
requests.exceptions.MissingSchema: Invalid URL '0/80008341/720p.mp4?kcd=AAAAAABAr0A': No scheme supplied. Perhaps you meant https://0/80008341/720p.mp4?kcd=AAAAAABAr0A?
[PYI-889378:ERROR] Failed to execute script 'kinescope-dl' due to unhandled exception!

image

@vasilake-v

Copy link
Copy Markdown
Author

Hey @salmiakki

After opening I noticed there is another, related to fixing the files urls, PR #27 🙈

Feel free to close this one if it's not necessary :)

Thanks!

@salmiakki

Copy link
Copy Markdown
Contributor

@vasilake-v I am not a maintainer :)

@vasilake-v

Copy link
Copy Markdown
Author

@salmiakki , oh, yes you're right, @anijackich is.

I 'll redirect my previous statement to @anijackich then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants