Repository navigation
Address follow-up workshop review feedback - #2
Merged
giolaq merged 8 commits intoSep 29, 2026
Merged
Conversation
giolaq
changed the title
Collaborator
Author
|
Tested on the real device ✅ |
anishamalde
reviewed
Sep 28, 2026
|
|
||
| Before continuing, launch the app and confirm that it still shows the Step 5 | ||
| screen: the navigation tile row and the horizontal movie list must both be | ||
| visible. If you have already completed Step 7, restore the Step 5 screen before |
Owner
There was a problem hiding this comment.
I would remove the line about having completed step 7 - if someone jumps ahead thats on them
anishamalde
reviewed
Sep 28, 2026
| If the list is empty, connect a physical Vega device before continuing. See [Step 1: Run on a Fire TV Stick](./step-01-setup-and-run.md#run-on-a-fire-tv-stick) if you need to configure the device. | ||
|
|
||
| UI Fluidity testing requires Appium `2.2.2` and the Vega `kepler` Appium driver `3.30.0`. KPI Visualizer also lists `@amazon-devices/kepler-performance-api` as a prerequisite. | ||
| Copy the physical device serial from the first column and use it throughout the |
Owner
There was a problem hiding this comment.
Can you please do a pass through to make sure the language is the same as the other sections?
anishamalde
reviewed
Sep 28, 2026
|
|
||
| ## 6.3 Choose how to run the measurement | ||
| ```bash | ||
| vega exec perf generate-test-template \ |
Owner
There was a problem hiding this comment.
Is there a reason we are going for a custom test?
Collaborator
Author
There was a problem hiding this comment.
When I run the default UI Fluidity test it does not enter this app’s movie list. The custom scenario focuses Movies, enters the list and performs the horizontal scrolling for both FlatList and Carousel.
anishamalde
requested changes
Sep 28, 2026
Collaborator
Author
|
Updated with the default test after your changes to the movie list, can you merge so the workshop can be tested from 0 to 7? |
anishamalde
reviewed
Sep 29, 2026
| If the list is empty, connect a physical Vega device before continuing. See [Step 1: Run on a Fire TV Stick](./step-01-setup-and-run.md#run-on-a-fire-tv-stick) if you need to configure the device. | ||
|
|
||
| UI Fluidity testing requires Appium `2.2.2` and the Vega `kepler` Appium driver `3.30.0`. KPI Visualizer also lists `@amazon-devices/kepler-performance-api` as a prerequisite. | ||
| Copy the physical device serial from the first column and use it throughout the |
Owner
There was a problem hiding this comment.
What do you mean by first column?
anishamalde
reviewed
Sep 29, 2026
anishamalde
reviewed
Sep 29, 2026
|
|
||
| Do not assume that the Carousel will always produce a particular number. Device state, images, background activity, and the exact focus path can affect the result. The useful outcome is learning how to make a repeatable comparison. | ||
|
|
||
| If you want to investigate a failing result after the workshop, Amazon's [Investigate UI Fluidity Issues](https://developer.amazon.com/docs/vega/0.24/investigate-ui-fluidity.html) guide explains CPU profiling and trace analysis. |
Owner
There was a problem hiding this comment.
Can you add example results?
anishamalde
reviewed
Sep 29, 2026
anishamalde
reviewed
Sep 29, 2026
| 4. Play/Pause works. | ||
| 5. Back or Exit returns to the movie row. | ||
|
|
||
| Manual testing with the Virtual Device remote is enough for this step. Appium |
anishamalde
reviewed
Sep 29, 2026
anishamalde
approved these changes
Sep 29, 2026
anishamalde
left a comment
anishamalde
left a comment
Owner
There was a problem hiding this comment.
Approving but please address the small comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --checkstreaming-tv-prompt.txtis the only prompt remaining