Repository navigation
Fix starter tooling so type checks, tests, and lint run - #3
Merged
Merged
Conversation
Several validation commands failed on a fresh clone before any workshop changes, which also blocks the Step 7 prompt's validation list: - shared: tsconfig used moduleResolution "bundler", which TypeScript 4.9 rejects; switch to "node" and map @amazon-devices/* and lottie-react-native to the Vega workspace. - shared: the @testing-library/react-native Jest preset no longer exists; use the Vega workspace's React Native preset and module paths, and enable RNTL's built-in matchers. - vega: shared files couldn't resolve react-native/react during ts-jest type checks or at runtime; add tsconfig paths and Jest modulePaths. - vega: replace the stale template test (it looked for a "sampleLink" testID that doesn't exist) with a render test of the home tiles. - expotv: add eslint and eslint-config-expo so `yarn lint` runs. - expotv: add `yarn typecheck` with tsconfig.typecheck.json. It keeps the React type mappings out of tsconfig.json (which Expo Metro reads) and includes Expo's types, since expo-env.d.ts only exists after `expo start`.
Fix starter tooling so type checks, tests, and lint run
anishamalde
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix starter tooling so type checks, tests, and lint run
Several validation commands failed on a fresh clone before any workshop
changes, which also blocks the Step 7 prompt's validation list:
rejects; switch to "node" and map @amazon-devices/* and
lottie-react-native to the Vega workspace.
use the Vega workspace's React Native preset and module paths, and
enable RNTL's built-in matchers.
type checks or at runtime; add tsconfig paths and Jest modulePaths.
testID that doesn't exist) with a render test of the home tiles.
yarn lintruns.yarn typecheckwith tsconfig.typecheck.json. It keeps theReact type mappings out of tsconfig.json (which Expo Metro reads) and
includes Expo's types, since expo-env.d.ts only exists after
expo start.