Make auth root navigation single-owned - #163
Merged
Merged
Conversation
artiphishle
marked this pull request as ready for review
July 25, 2026 10:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #162
Summary
/entry route navigation-neutral for auth apps with a non-root post-sign-in routeRedirect,withAnchor, and synthetic initial-history behavior from that routerouter.replace(...)after auth bootstrapinitialRouteNamestructure for natural navigator behaviorRoot cause
The generated
/entry and the generated root layout both owned the transition to/products:src/app/index.tsxrendered an Expo RouterRedirectwithwithAnchor./with the authenticated post-sign-in target after auth bootstrap.Anchoring the redirect reconstructed nested navigator history and could expose a Back button, including an
initial=falsenavigation parameter workaround. The route transition therefore had competing owners.Solution
The generated
src/app/index.tsxremains as a renderless route so Expo Router can match/, but it no longer imports or invokes the router. It returnsnullwhile the root layout resolves authentication and performs the only canonicalizing navigation:This preserves the auth bootstrap boundary introduced in #155 without creating synthetic Back history.
Expected behavior
/while authenticated resolves to/productswith no Back button/productsdirectly has the same effective navigation rootinitial=false,withAnchor, or header-hiding workaround is generated/entry still resolves through the root auth boundaryValidation
Focused Bun generation coverage now verifies:
/remains matchable through a navigation-neutral index routeRedirect,withAnchor, orinitialoverriderouter.replace(...)Full repository validation is delegated to CI because this change was authored through the connected GitHub environment.