fix: add reusable inverse surface semantics for tooltips - #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the unreadable Tooltip contrast reported in #60 by introducing a reusable, mode-aware inverse surface/content semantic pair in Surface.
What changed
theme.semantics.surface.inverseas a first-class reusable semantic tokentheme.semantics.content.inverseas the paired neutral foreground for the inverse surfaceTextwith an explicit semantic color still resolves that role'sonSolidTextTooltipto usetheme.semantics.surface.inverseinstead of repurposingneutral.textas a backgroundResult
The centralized pair is:
This is intentionally not Tooltip-specific. Any Surface/ZORA component or pattern can reuse the same inverse semantics.
Root cause
Tooltip previously combined:
theme.semantics.neutral.texttheme.semantics.content.inverseBut global
content.inversewas aliased tobrand.onSolidText, which is calculated forbrand.base, not for a neutral tooltip background. The foreground and background therefore had no guaranteed contrast relationship and Tooltip readability could depend on the configured primary color.Validation
Added pure Bun regression tests covering:
brand.onSolidTextLocal execution was not available in the current agent environment because the GitHub CLI is absent and outbound network access prevented cloning/installing the repository. Repository CI should provide the executable validation for the pushed branch.
Closes #60