Repository navigation
test(platform-node): wait for the shard close report, not the client - #1610
Conversation
The client can see CLOSED before the server's close handler reports to the shard, so on a slow runner the assertion ran first and the test failed on Node 22 in CI. It now waits on the report. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for lunorash ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
|
|
Thank you for following the naming conventions! 🙏 |
PR Summary by QodoWait for the shard close report in the Node WebSocket test
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR |
1 similar comment
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR |
Merging this PR will not alter performance
Comparing Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #1610 +/- ##
===========================================
+ Coverage 84.48% 92.31% +7.82%
===========================================
Files 2130 22 -2108
Lines 131392 2237 -129155
Branches 33406 447 -32959
===========================================
- Hits 111006 2065 -108941
+ Misses 19623 168 -19455
+ Partials 763 4 -759 🚀 New features to boost your workflow:
|
Summary
tells the shard about a close the shard itself initiatedwaited for the client socket to reachCLOSEDand then asserted that the shard had received the close event. The server'swsclose handler reports to the shard independently of the client's view, so on a slow runner the assertion ran first. It failed onTest (node-22.22)for several unrelated PRs (#1518, #1609).The test now waits for the shard's close report itself, which is the milestone it asserts on.
Verification
notifyClosedby 100 ms makes the old test fail and the new one pass.websocket-upgrade.test.tssuite passes: 13 of 13.🤖 Generated with Claude Code