Repository navigation
test(vite): satisfy prefer-expect-assertions on studio-plugin test - #178
Conversation
#172 replaced `expect.hasAssertions()` with an unconditional `expect([200, 501])` to survive the unbuilt-studio (501) path, but that trips `vitest/prefer-expect-assertions` (fails under --max-warnings=0 whenever a PR makes @lunora/vite affected). Restore `expect.hasAssertions()` as the first expression — now safe because the unconditional assertion guarantees ≥1 on every path — satisfying both the rule and the 501 environment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0197KjhmBDB3PXAc6TXiPqZ9
✅ Deploy Preview for lunorash ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for following the naming conventions! 🙏 |
|
Thank you for confirming the Contributor License Agreement! 🙏 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Follow-up to #172: restore
expect.hasAssertions()as the first expression of the studio-plugin ETag test (the unconditionalexpect([200,501])guarantees ≥1 assertion, so it's safe on the unbuilt-studio path). Clears avitest/prefer-expect-assertionswarning that failsLint (eslint)(--max-warnings=0) on any PR making @lunora/vite affected — currently blocking #173/#174.🤖 Generated with Claude Code