Skip to content

fix(search-core): derive the prefix upper bound from the last code point, not code unit - #302

Closed
prisis wants to merge 1 commit into
alphafrom
advisor/272-search-astral-prefix-bound
Closed

prisis wants to merge 1 commit into
alphafrom
advisor/272-search-astral-prefix-bound

Conversation

@prisis

@prisis prisis commented Aug 2, 2026

Copy link
Copy Markdown
Member

Branched before #288/#289 landed, so it needs a rebase onto current alpha before merge.

Commits

  • fix(search-core): derive the prefix upper bound from the last code point, not code unit

Files this branch still changes relative to alpha

packages/search-core/__tests__/query.test.ts
packages/search-core/src/query.ts
packages/shard-engine/__tests__/ctx-db.search.test.ts
packages/sql-store/__tests__/ctx-db-search.test.ts

…int, not code unit

searchTermRange computed "the last code point" via
token.codePointAt(token.length - 1) — a code-UNIT index. For a token ending
in a surrogate pair this reads the lone low surrogate rather than the true
character. Most astral tokens happen to survive the resulting increment
(the pair re-forms by luck), but a token whose low surrogate sits at the top
of its range (0xDFFF) escapes the surrogate block on increment, and a token
ending exactly at U+D7FF (the Hangul block boundary) increments straight
into the surrogate range — both produce an invalid lone-surrogate bound that
a UTF-8 binding mangles to U+FFFD, corrupting the inverted-index range scan
for the term the user is still typing.

Take the last character via spread (code-point iteration, not code-unit
index) and increment its true code point. When the successor would itself
be a surrogate value or exceed U+10FFFF, degrade to an exact match instead
of a widened range — never wrong, merely narrower, and only reachable at
those two boundaries.

Added astral-prefix regression coverage in both consuming engines
(@lunora/shard-engine, @lunora/sql-store) alongside the unit-level pins.
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@prisis, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c192aa60-fc3f-45e6-86d8-4304fad43e5e

📥 Commits

Reviewing files that changed from the base of the PR and between 6a4dd72 and d4faa4d.

⛔ Files ignored due to path filters (3)
  • packages/search-core/__tests__/query.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/shard-engine/__tests__/ctx-db.search.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/sql-store/__tests__/ctx-db-search.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
📒 Files selected for processing (1)
  • packages/search-core/src/query.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for confirming the Contributor License Agreement! 🙏

@netlify

netlify Bot commented Aug 2, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for lunorash failed.

Name Link
🔨 Latest commit d4faa4d
🔍 Latest deploy log https://app.netlify.com/projects/lunorash/deploys/6a6f0b54474bd80008cedbb8

@prisis

prisis commented Aug 2, 2026

Copy link
Copy Markdown
Member Author

Closing: this PR was opened in error by an automated run, outside the scope of its task.

No work is lost — the branch is retained on origin and this PR can be reopened at any time.

Context: this branch predates the merges of #288 and #289, so much of its content is already on alpha, and it would need a rebase before being reviewable. Reopening deliberately, after a rebase, is preferable to leaving it open in this state.

@prisis prisis closed this Aug 2, 2026
@prisis
prisis deleted the advisor/272-search-astral-prefix-bound branch August 2, 2026 09:46
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant