Repository navigation
Conversation
…4001 The voice-session DO captured the caller's identity at WebSocket upgrade and replayed it into every turn's dispatch runner for the socket's whole life, but never read the x-lunora-identity-exp header the runtime already forwards on that same upgrade. A voice socket was effectively an unexpiring credential: revoking or expiring a user's session did not terminate an open voice socket, so every thread write it made kept being attributed to (and authorized as) that user indefinitely. Mirror the sibling ShardDO's existing pattern: stamp the parsed expiry (epoch ms) onto the hibernation attachment at upgrade, and check it at the single message entry point before dispatching a control frame or buffering audio. An expired socket gets the same TOKEN_EXPIRED error frame and 4001 close code ShardDO already sends, so a client handling one handles both. Absent or malformed headers keep today's behavior (never auto-expire) — additive only.
… step The needsApproval gate was awaited outside any durable step, so on every workflow replay (a retried step, a resumed hibernation, an approval wake) the user's callback re-ran — including any run()/setState() it triggered through the tool context it was handed. Worse, a gate whose answer depends on getState() could flip false to true between the original pass and a replay, routing the replay into an approval wait no client would ever resolve and hanging the instance until the workflow timeout. Wrap only the dynamic (function) gate in its own durable step (tool:approval-gate:<call.id>, distinct from the tool's own step so @lunora/workflow's by-name memoization can't confuse the two) so it resolves exactly once per call. The boolean/undefined forms stay outside any step since replay re-derives them identically for free. The gate now receives a read-only AgentApprovalContext (no setState) instead of the full tool context, formalizing the existing rule that a gate must not mutate state.
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for following the naming conventions! 🙏 |
❌ Deploy Preview for lunorash failed.
|
|
Thank you for confirming the Contributor License Agreement! 🙏 |
|
Closing: this PR was opened in error by an automated run, outside the scope of its task. No work is lost — the branch is retained on origin and this PR can be reopened at any time. Context: this branch predates the merges of #288 and #289, so much of its content is already on |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Branched before #288/#289 landed, so it needs a rebase onto current alpha before merge.
Commits
Files this branch still changes relative to alpha