Skip to content

fix(auth): record sign-in completion endpoints, fix a response-clobbering hook bug, and validate audit-read options - #306

Closed
prisis wants to merge 1 commit into
alphafrom
advisor/280-auth-audit-classification
Closed

prisis wants to merge 1 commit into
alphafrom
advisor/280-auth-audit-classification

Conversation

@prisis

@prisis prisis commented Aug 2, 2026

Copy link
Copy Markdown
Member

Branched before #288/#289 landed, so it needs a rebase onto current alpha before merge.

Commits

  • fix(auth): record sign-in completion endpoints, fix a response-clobbering hook bug, and validate audit-read options

Files this branch still changes relative to alpha

packages/auth/__tests__/audit-hooks.behaviour.test.ts
packages/auth/__tests__/audit.test.ts
packages/auth/__tests__/auth-do.behaviour.test.ts
packages/auth/src/audit-hooks.ts
packages/auth/src/audit.ts
packages/auth/src/auth-do.ts

…ring hook bug, and validate audit-read options

The audit trail misclassified /sign-in/social and /sign-in/magic-link
(which only dispatch a redirect/email) as completed sign-ins, while
/callback/:id, /magic-link/verify, and every /two-factor/verify-*
endpoint -- where a session is actually issued -- were never recorded
at all. Split dispatch from completion: the two dispatch-only paths
now record sign-in-initiated, and the four completion endpoints join
credential sign-ins as sign-in. A failed sign-in now also carries
targetEmail (the attempted identifier, read from the request body) as
a top-level column -- never inside detail, since @visulima/redact
scrubs email-shaped values there regardless of key name -- so
credential-stuffing attempts can be grouped by target even without an
authenticated actor.

Pinning the better-auth 1.7.0-rc.2 hook contract against a real
instance (packages/auth/__tests__/audit-hooks.behaviour.test.ts)
surfaced two things beyond what was being pinned:

1. better-auth runs the app's own hooks.after BEFORE a plugin's after
   hooks, so authAuditHook cannot observe the two-factor plugin's
   {twoFactorRedirect:true} rewrite -- a "sign-in-challenged" event
   is not observable from this hook and is not implemented here.
2. authAuditHook's trailing `return {};` is a live bug: better-auth's
   after-hook runner treats any non-undefined return as the endpoint's
   new response, so returning {} silently replaced every hooked
   endpoint's response body with {} -- sign-up, sign-in, everything.
   Fixed to `return undefined;`, which does not throw (the removed
   comment's claim otherwise was false) and is a true no-op.

Also hardens the audit-read boundary: AuthDO#readAudit now parses and
validates the request body instead of trusting it, returning 400 for
a malformed body or an unknown/ill-typed option instead of throwing
(a 500) or letting a non-numeric limit reach the SQL LIMIT clause as
NaN. readAuthAuditLog's own clamp is NaN-safe independent of that
boundary, protecting every other caller too.

onRecord/SIEM consumers keyed on event strings will see fewer
sign-in events for social/magic-link dispatch and more for the
previously-unrecorded completion endpoints -- see the mapping table
in authAuditHook's docblock.
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@prisis, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a82b8f31-efae-4b1d-9539-04abbf4d0894

📥 Commits

Reviewing files that changed from the base of the PR and between 6a4dd72 and 1bf5ff3.

⛔ Files ignored due to path filters (3)
  • packages/auth/__tests__/audit-hooks.behaviour.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/auth/__tests__/audit.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/auth/__tests__/auth-do.behaviour.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
📒 Files selected for processing (3)
  • packages/auth/src/audit-hooks.ts
  • packages/auth/src/audit.ts
  • packages/auth/src/auth-do.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@netlify

netlify Bot commented Aug 2, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for lunorash failed.

Name Link
🔨 Latest commit 1bf5ff3
🔍 Latest deploy log https://app.netlify.com/projects/lunorash/deploys/6a6f0b669701b0000806afe9

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for confirming the Contributor License Agreement! 🙏

@prisis

prisis commented Aug 2, 2026

Copy link
Copy Markdown
Member Author

Closing: this PR was opened in error by an automated run, outside the scope of its task.

No work is lost — the branch is retained on origin and this PR can be reopened at any time.

Context: this branch predates the merges of #288 and #289, so much of its content is already on alpha, and it would need a rebase before being reviewable. Reopening deliberately, after a rebase, is preferable to leaving it open in this state.

@prisis prisis closed this Aug 2, 2026
@prisis
prisis deleted the advisor/280-auth-audit-classification branch August 2, 2026 09:46
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant