Skip to content

docs: reconcile AGENTS.md package table with the workspace - #310

Closed
prisis wants to merge 5 commits into
alphafrom
advisor/289-auth-ui-api-snapshot
Closed

prisis wants to merge 5 commits into
alphafrom
advisor/289-auth-ui-api-snapshot

Conversation

@prisis

@prisis prisis commented Aug 2, 2026

Copy link
Copy Markdown
Member

Branched before #288/#289 landed, so it needs a rebase onto current alpha before merge.

Commits

  • docs: reconcile AGENTS.md package table with the workspace
  • build: add AGENTS.md package-table completeness check
  • build(deps): extend sibling guard to report dependencies drift
  • deps: normalize stale @lunora/* sibling pins to current versions
  • build(auth-ui): cover the auth-ui surface with the api-snapshot guard

Files this branch still changes relative to alpha

AGENTS.md
api-snapshots/auth-ui.api.md
package.json
packages/advisor/package.json
packages/agent/package.json
packages/auth/package.json
packages/cli/package.json
packages/client/package.json
packages/cloudflare-access/package.json
packages/codegen/package.json
packages/config/package.json
packages/d1/package.json
packages/db/package.json
packages/dispatch/package.json
packages/do/package.json
packages/hyperdrive/package.json
packages/lunora/package.json
packages/mcp/package.json
packages/observability/package.json
packages/payment/package.json
packages/platform-node/package.json
packages/ratelimit/package.json
packages/react/package.json
packages/runtime/package.json
packages/seed/package.json
packages/server/package.json
packages/solid/package.json
packages/sql-store/package.json
packages/studio/package.json
packages/svelte/package.json
packages/testing/package.json
packages/vite/package.json
packages/vue/package.json
pnpm-lock.yaml
scripts/api-snapshot.js
scripts/check-agents-md-packages.js
scripts/check-sibling-peer-ranges.js

prisis added 5 commits August 1, 2026 18:48
Add table rows for platform, shard-engine, platform-cloudflare,
platform-node, and auth-ui, relocate the observability row next to its
platform-family siblings, rewrite the "exactly two packages" prose to
match the five packages on disk, and correct the advisor row's stale
rule count (81 -> ~95, with a pointer to the live STATIC_LINTS array).
AGENTS.md is the file every coding agent reads to decide which package
owns a change, and it has silently drifted out of sync with
packages/* five times already (auth-ui, platform, platform-cloudflare,
platform-node, shard-engine). Add check-agents-md-packages.js to the
postinstall chain so a new package with no AGENTS.md mention fails the
next install instead of going unnoticed.
check-sibling-peer-ranges.js only ever walked peerDependencies, so an
exact @lunora/* dependencies pin drifting behind its sibling's current
version was invisible. multi-semantic-release's "satisfy" bump mode
only re-pins a consumer's dependencies on the consumer's own next
release, so a rarely-releasing (or private, never-released) consumer
can carry a stale pin indefinitely -- which means two published
@lunora/* packages installed together can resolve two physical copies
of a shared sibling.

Add a second, report-only pass over dependencies (never failing the
install, since mid-release-train drift is expected) alongside the
existing exact-peer-pin gate. Baseline: 63 stale pins across 30
packages, captured below.

Before (pre-sweep tree, this script): 63 warnings, one per stale pin,
e.g. "packages/do depends on \"@lunora/platform-cloudflare\":
\"1.0.0-alpha.1\" -- current is \"1.0.0-alpha.2\".", ending in a
one-line summary count.
After (post-sweep, next commit): 0 warnings.
63 exact dependencies pins across 30 packages had drifted behind the
sibling's current published version -- @lunora/errors alone was split
three ways (alpha.8/alpha.10/alpha.11 against a current alpha.11). Set
every stale specifier to its dependency's current version field;
version fields themselves are untouched (releases stay automation-
owned). Regenerated pnpm-lock.yaml to match.

Re-derivation after this commit reports 0 stale pins; the extended
check-sibling-peer-ranges.js guard reports 0 dependency warnings.
@lunora/auth-ui was in neither TIER_1/TIER_2 nor the documented
exclusion list -- unlike every other uncovered package, it had no
written rationale, so a reader couldn't tell whether that was a
decision or an oversight. It also has the widest new public surface in
the repo (a controller-per-screen core consumed by five framework
ports) and the highest churn, with no CI signal on a renamed or dropped
export.

auth-ui is private, has no build script, and its exports map points at
raw `.ts` source rather than a `types` condition, so collectEntries
skipped it entirely and a plain tier-add would have rendered
"_No exports._" -- a green gate guarding nothing. Add a fallback that
accepts a plain-string exports value ending in .ts/.tsx as an entry,
extracted straight from source, and add auth-ui to TIER_2.

Verified: the fallback doesn't perturb any of the 43 existing
snapshots; two consecutive `api:update` runs produce identical output;
a scratch rename of `createAccountsController` makes `api-snapshot.js
check` fail naming the auth-ui surface, and reverting it passes again.
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@prisis, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b4a86a43-17d9-45e9-985b-0bc6c78233a7

📥 Commits

Reviewing files that changed from the base of the PR and between 6a4dd72 and 1a61938.

⛔ Files ignored due to path filters (4)
  • AGENTS.md is excluded by none and included by none
  • api-snapshots/auth-ui.api.md is excluded by none and included by none
  • package.json is excluded by none and included by none
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml and included by none
📒 Files selected for processing (33)
  • packages/advisor/package.json
  • packages/agent/package.json
  • packages/auth/package.json
  • packages/cli/package.json
  • packages/client/package.json
  • packages/cloudflare-access/package.json
  • packages/codegen/package.json
  • packages/config/package.json
  • packages/d1/package.json
  • packages/db/package.json
  • packages/dispatch/package.json
  • packages/do/package.json
  • packages/hyperdrive/package.json
  • packages/lunora/package.json
  • packages/mcp/package.json
  • packages/observability/package.json
  • packages/payment/package.json
  • packages/platform-node/package.json
  • packages/ratelimit/package.json
  • packages/react/package.json
  • packages/runtime/package.json
  • packages/seed/package.json
  • packages/server/package.json
  • packages/solid/package.json
  • packages/sql-store/package.json
  • packages/studio/package.json
  • packages/svelte/package.json
  • packages/testing/package.json
  • packages/vite/package.json
  • packages/vue/package.json
  • scripts/api-snapshot.js
  • scripts/check-agents-md-packages.js
  • scripts/check-sibling-peer-ranges.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Aug 2, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for lunorash failed.

Name Link
🔨 Latest commit 1a61938
🔍 Latest deploy log https://app.netlify.com/projects/lunorash/deploys/6a6f0b79a6fb860008070b3d

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for confirming the Contributor License Agreement! 🙏

@prisis

prisis commented Aug 2, 2026

Copy link
Copy Markdown
Member Author

Closing: this PR was opened in error by an automated run, outside the scope of its task.

No work is lost — the branch is retained on origin and this PR can be reopened at any time.

Context: this branch predates the merges of #288 and #289, so much of its content is already on alpha, and it would need a rebase before being reviewable. Reopening deliberately, after a rebase, is preferable to leaving it open in this state.

@prisis prisis closed this Aug 2, 2026
@prisis
prisis deleted the advisor/289-auth-ui-api-snapshot branch August 2, 2026 09:58
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.