Skip to content

fix(errors): register CRON_SCHEDULE_INVALID, allowlist two non-LunoraError codes - #312

Closed
prisis wants to merge 2 commits into
alphafrom
advisor/293-catalog-registration-scope
Closed

prisis wants to merge 2 commits into
alphafrom
advisor/293-catalog-registration-scope

Conversation

@prisis

@prisis prisis commented Aug 2, 2026

Copy link
Copy Markdown
Member

Branched before #288/#289 landed, so it needs a rebase onto current alpha before merge.

Commits

  • fix(errors): register CRON_SCHEDULE_INVALID, allowlist two non-LunoraError codes
  • test(errors): widen the catalog-registration gate to the whole repo

Files this branch still changes relative to alpha

packages/errors/__tests__/catalog-registration.test.ts
packages/errors/src/catalog.ts

prisis added 2 commits August 1, 2026 19:11
…Error codes

The catalog-registration gate has been failing at baseline on three
long-committed codes: SUBSCRIPTION_CANCELLED and REQUEST_ENTITY_TOO_LARGE
are plain object-literal error payloads that never construct a LunoraError,
so they get a documented allowlist entry instead of a catalog registration.
CRON_SCHEDULE_INVALID is minted onto a CodegenDiagnosticError (a LunoraError
subclass) via diagnosticAt's Object.assign, so it genuinely needs a catalog
entry — added alongside its sibling CRON_*_NOT_STATIC/_INVALID codes, which
are already documented as build-time-only and deliberately not internal.
Walk from REPO_ROOT instead of packages/*/src so registry/, shared/,
templates/, sdks/, protocol/, tools/, apps/, and examples/ are covered —
an unregistered code is treated as client-safe, and registry/templates/
examples are exactly the code users copy into their own apps. The
new LunoraError(...) capture group now tolerates any case, since a mint's
first argument is unambiguously a code regardless of casing; the code:
object-literal group stays SCREAMING_SNAKE_CASE-only to avoid flagging
unrelated literals (key names, locale tags, driver error codes) repo-wide.
Adds the three SQL_* SqlRejectionCode values to the non-LunoraError
allowlist alongside the existing REQUEST_ENTITY_TOO_LARGE/
SUBSCRIPTION_CANCELLED entries, with an integrity assertion that keeps
each allowlist entry honest.
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@prisis, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6a119c6b-5212-48e6-bd45-9697a99d2009

📥 Commits

Reviewing files that changed from the base of the PR and between 6a4dd72 and 9a7a905.

⛔ Files ignored due to path filters (1)
  • packages/errors/__tests__/catalog-registration.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
📒 Files selected for processing (1)
  • packages/errors/src/catalog.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Aug 2, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for lunorash failed.

Name Link
🔨 Latest commit 9a7a905
🔍 Latest deploy log https://app.netlify.com/projects/lunorash/deploys/6a6f0b82d8cf9e0008e4df39

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for confirming the Contributor License Agreement! 🙏

@prisis

prisis commented Aug 2, 2026

Copy link
Copy Markdown
Member Author

Closing: this PR was opened in error by an automated run, outside the scope of its task.

No work is lost — the branch is retained on origin and this PR can be reopened at any time.

Context: this branch predates the merges of #288 and #289, so much of its content is already on alpha, and it would need a rebase before being reviewable. Reopening deliberately, after a rebase, is preferable to leaving it open in this state.

@prisis prisis closed this Aug 2, 2026
@prisis
prisis deleted the advisor/293-catalog-registration-scope branch August 2, 2026 09:46
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant