Repository navigation
Conversation
…gnostic
A table declared with a non-identifier key (e.g. "user-profiles") was
interpolated raw into generated type names (`Doc_${name}`) and unquoted
property keys, so a project with such a schema failed the build with a
cascade of confusing tsc parse errors on generated code instead of one
clear diagnostic on the schema line. Discovery now rejects it up front
with a `file:line:column`-pinned error, extending the existing
reserved-table-name gate. Also normalizes a quoted string-literal table
key (`property.getName()` includes the surrounding quotes) before both
the reserved-name and identifier checks, closing a related blind spot
where a quoted `"delete"` key slipped past the reserved-name set.
…ackage list
`UMBRELLA_QUALIFIER_RE` rewrote checker-rendered `import("@lunora/<pkg>")`
type qualifiers to `lunorash/*` for only five packages, while the
umbrella actually re-exports ten — `errors`, `flags`, `observability`,
`platform`, and `ratelimit` were missing, and the sibling specifier map
in the same file had already drifted from it once (it lists `flags`).
The regex is now derived from one `UMBRELLA_BASE_PACKAGES` list, and a
new test asserts that list stays in sync with the umbrella's own
package.json exports in both directions.
Deep-subpath forwarding is constrained per package: `flags` and
`platform` each expose subpaths the umbrella does not mirror 1:1
(`@lunora/flags`'s `/providers/env` etc. are flattened to `/env` in the
umbrella; `@lunora/platform`'s `/conformance` isn't re-exported by the
umbrella at all), so forwarding those verbatim would rewrite into a
`lunorash/*` specifier that does not resolve. Only a subpath known to
be mirrored (or no subpath) is rewritten for those two; every other
covered package mirrors all its subpaths and is unaffected.
No repro of a checker-rendered qualifier for any of the five newly
covered packages was found during investigation (nor, within the
timebox, for the existing five) — the widening is drift-proofing
against a latent gap, not a demonstrated fix for an observed failure.
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ Deploy Preview for lunorash failed.
|
|
Thank you for following the naming conventions! 🙏 |
|
Thank you for confirming the Contributor License Agreement! 🙏 |
|
Closing: this PR was opened in error by an automated run, outside the scope of its task. No work is lost — the branch is retained on origin and this PR can be reopened at any time. Context: this branch predates the merges of #288 and #289, so much of its content is already on |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Branched before #288/#289 landed, so it needs a rebase onto current alpha before merge.
Commits
Files this branch still changes relative to alpha