Repository navigation
Conversation
…onable error `SocketHost.accept` prepends a synthesized identity tag to every caller-supplied tag list before calling `state.acceptWebSocket`, but the contract states no tag-count or length budget. A caller who reads the contract and passes Cloudflare's full tag allowance got a runtime throw from `acceptWebSocket` naming a tag it never supplied — the provider limit leaking through a contract whose purpose is to hide it. Cloudflare's documented cap is 10 tags per socket, 256 characters each (developers.cloudflare.com/durable-objects/api/state/, checked 2026-08-01). With one slot reserved for the host's own identity tag, the adapter now validates the caller's tag count and each tag's length *before* calling `acceptWebSocket`, throwing a `SOCKET_TAG_BUDGET_EXCEEDED` `LunoraError` that names the counts and the reservation, instead of letting the provider throw an opaque error blaming the combined list. Adds `@lunora/errors` as a dependency of `@lunora/platform-cloudflare` (previously absent) for the coded, catalog-registered error.
…cept `SocketHost.accept`'s docstring and the module-header tag-tier discussion said nothing about a tag-count or length budget, even though Cloudflare's `acceptWebSocket` enforces one (10 tags / 256 characters) and the adapter reserves one slot for its own identity tag. Documents the reserved-slot model in provider-neutral terms: a portable caller should assume at most 9 usable tags of at most 256 characters, with Cloudflare named as the motivating example. Also adds a conformance-suite leg asserting the portable floor of nine caller tags resolves correctly via `getSockets(tag)` on every host. On the Cloudflare host this lands exactly at the provider's 10-tag cap (9 + 1 reserved), so it is a regression fence — it fails the moment a second reserved slot is added without updating the documented budget, not a reproduction of the bug the sibling fix commit addresses.
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ Deploy Preview for lunorash failed.
|
|
Thank you for following the naming conventions! 🙏 |
|
Thank you for confirming the Contributor License Agreement! 🙏 |
|
Closing: this PR was opened in error by an automated run, outside the scope of its task. No work is lost — the branch is retained on origin and this PR can be reopened at any time. Context: this branch predates the merges of #288 and #289, so much of its content is already on |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Branched before #288/#289 landed, so it needs a rebase onto current alpha before merge.
Commits
Files this branch still changes relative to alpha