Skip to content

fix(ci): make the Netlify ignore step work without pnpm on PATH - #318

Closed
prisis wants to merge 2 commits into
alphafrom
work/netlify-secret-fix
Closed

prisis wants to merge 2 commits into
alphafrom
work/netlify-secret-fix

Conversation

@prisis

@prisis prisis commented Aug 2, 2026

Copy link
Copy Markdown
Member

Branched before #288/#289 landed, so it needs a rebase onto current alpha before merge.

Commits

  • fix(ci): make the Netlify ignore step work without pnpm on PATH
  • fix(auth-ui): silence a false-positive secret-scanner hit

Files this branch still changes relative to alpha

apps/docs/netlify.toml
packages/auth-ui/src/angular/auth-cards.ts

prisis added 2 commits August 2, 2026 09:25
The build.ignore command shelled out via `pnpm exec`, but Netlify's
Ignored Build Step runs before Node/Corepack/pnpm are provisioned, so
the command always failed with "pnpm: command not found". Netlify's
inverted exit semantics read that failure as "proceed", so the
graph-aware skip has never actually fired and the docs site has
rebuilt on every push regardless of relevance.

Invoke the vis binary directly by its node_modules/.bin path instead
of through pnpm, since the pnpm-generated shim there only needs node
(already on PATH at this point) and never touches pnpm itself. Guard
it with a `[ -x ... ] || exit 1` fallback so a cold build with no
cached node_modules yet fails safe (build proceeds) instead of
crashing or silently skipping a needed deploy.
The reset-password-otp-card's Angular template binds
`t.resetPasswordOtpDescription` — an i18n translation-key property
access — which kingfisher's generic entropy/keyword rule
(kingfisher.generic.5, low) flags as a possible credential.

A `//` suppression comment isn't valid inside the template literal's
HTML, so the marker is an HTML comment instead: `vis secrets` matches
`secret-scanner:allow` as a substring of the source line regardless of
comment syntax, and HTML comments never produce visible output in any
browser. Verified empirically: `pnpm exec vis secrets` no longer flags
the file, `pnpm exec prettier --check` passes, and
`pnpm --filter "@lunora/auth-ui" run lint:types` is clean.
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@prisis, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8855cfb7-caf0-4c80-aa6a-a97dc2be5751

📥 Commits

Reviewing files that changed from the base of the PR and between 6a4dd72 and cb2157d.

📒 Files selected for processing (2)
  • apps/docs/netlify.toml
  • packages/auth-ui/src/angular/auth-cards.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Aug 2, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for lunorash failed.

Name Link
🔨 Latest commit cb2157d
🔍 Latest deploy log https://app.netlify.com/projects/lunorash/deploys/6a6f0b9eff7fe300081131c5

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@codspeed

codspeed Bot commented Aug 2, 2026

Copy link
Copy Markdown

This PR has no benchmarks

⚠️ No benchmarks were detected in both the base of the PR and the PR.
Please ensure that your benchmarks are correctly instrumented with CodSpeed.

Check out the benchmarks creation guide


Comparing work/netlify-secret-fix (cb2157d) with alpha (6a4dd72)

Open in CodSpeed

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for confirming the Contributor License Agreement! 🙏

@prisis

prisis commented Aug 2, 2026

Copy link
Copy Markdown
Member Author

Closing: this PR was opened in error by an automated run, outside the scope of its task.

No work is lost — the branch is retained on origin and this PR can be reopened at any time.

Context: this branch predates the merges of #288 and #289, so much of its content is already on alpha, and it would need a rebase before being reviewable. Reopening deliberately, after a rebase, is preferable to leaving it open in this state.

@prisis prisis closed this Aug 2, 2026
@prisis
prisis deleted the work/netlify-secret-fix branch August 2, 2026 09:47
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 8, 2026

This branch was previously deployed

1 inactive deployment
benchmarks — cb2157dc Deployed Aug 2, 2026 by prisis via Benchmarks #1369
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant