Repository navigation
Conversation
The React AuthView dispatched the URL segment through a plain object literal, which inherits Object.prototype. A segment naming an inherited member (valueOf, constructor, toString) resolved to that member instead of falling back to the sign-in card, crashing the page or rendering garbage. Guard the lookup with Object.hasOwn. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
createOrganizationLogoController still carried the exact predicate that avatar.ts was explicitly fixed for: a File with an empty type skipped the accept-list check entirely, letting arbitrary bytes through under any file name. Extract the shared isAcceptedImage helper out of avatar.ts and route both controllers through it, so the empty-type handling can't drift between the two copies again. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sharing isAcceptedImage between the avatar and org-logo controllers made the accept-list check async on every path, not just the empty-type sniff, shifting the upload call by one microtask. The existing test split its two assertions across a waitFor callback and a trailing expect() under expect.assertions(2), which over-counts on a waitFor retry; move both assertions inside the callback. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ered signUp flag The server can close self-serve sign-up via emailAndPassword.disableSignUp, and resolveContext already resolved it onto ControllerContext.signUp — but no port ever read it. SignUpCard still rendered a full form that fails on submit, AuthView still routed /auth/sign-up to it, and SignInCard's footer still advertised the link. Wire signUp through all three surfaces in all five ports, mirroring how the credentials flag is already consumed, and add a static parity test so the gap can't reopen silently in one port. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…n's existing query The invitation sign-in bounce appended ?redirectTo=... blindly, so an app whose redirects.signIn already carried a query (e.g. /auth?tab=sign-in, common when hosting every screen on one AuthView route) got a mangled second ? and the invitation was lost. Extract the parse-and-merge already proven in withRedirectTo into a mergeQuery helper, and route the bounce through it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…rade-off provider.tsx's core memo rebuilds every controller memoized on it when a discovery answer lands, which loses whatever the user already typed if this happens after they started. Measured rather than fixed: the realistic window is narrow for manual typing (a same-origin GET fired on mount usually resolves well before a human types), though a password manager's autofill can still race it. Both fix directions (a stable accessor through ControllerContext's public shape, or a generic seed/hydrate seam on Controller) are bigger than this plan's scope, so the trade-off is documented next to discoveryKey and pinned by a characterization test instead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
registry/auth-ui-{react,vue,svelte,solid,angular} mirror
packages/auth-ui/src and had drifted 113 files behind it, including the
empty-MIME avatar sniff, the open-redirect guard on social/magic-link/
one-tap callbackURLs, the stale-refetch generation counter, and every
fix from this session (the AuthView prototype guard, the org-logo
sniff, the signUp gate, and the invitation-bounce mergeQuery). Every
registry file scaffolded by `lunora registry add auth-ui-*` while this
drift was live carries the vulnerable/stale copies until re-synced by
hand; this closes that gap for new installs going forward. Generated
via `pnpm --filter @lunora/auth-ui sync:registry` — no hand edits.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The auth-ui registry drift check ran as the last step of the `prettier` job, gated on the frontend_lintable path filter and masked whenever an earlier step in that job failed — drift landed on alpha despite the check nominally existing in CI. Move it into its own always-run job (no path filter, modeled on the `secrets` job) and add it to lint-required-check's needs so a failure still blocks the single required status check. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (122)
📒 Files selected for processing (18)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ Deploy Preview for lunorash failed.
|
|
Thank you for confirming the Contributor License Agreement! 🙏 |
|
Thank you for following the naming conventions! 🙏 |
|
Closing: this PR was opened in error by an automated run, outside the scope of its task. No work is lost — the branch is retained on origin and this PR can be reopened at any time. Context: this branch predates the merges of #288 and #289, so much of its content is already on |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Work from an agent worktree, pushed under a descriptive name (local branch was
worktree-agent-adfed38045ccd5c2b).Branched before #288/#289 landed, so it needs a rebase onto current alpha before merge.
Commits