Skip to content

chore(platform-node): keep the spike host off npm until it is complete - #327

Merged
prisis merged 2 commits into
alphafrom
fix/platform-node-private
Aug 2, 2026
Merged

prisis merged 2 commits into
alphafrom
fix/platform-node-private

Conversation

@prisis

@prisis prisis commented Aug 2, 2026 •

Copy link
Copy Markdown
Member

Why

@lunora/platform-node landed as a plan-234 spike but was configured to publish: .releaserc.json present, publishConfig.access: public, version 0.0.0, never released. The next multi-semantic-release run from alpha would have shipped a half-finished host to npm as 1.0.0-alpha.1 — alarms that persist a timestamp nothing re-arms, a scheduler that stores jobs and never dispatches them, and no deploy driver.

What

Marks the package private and drops its .releaserc.json — the same pair @lunora/search-core and @lunora/dispatch carry, both of which 404 on npm. multi-semantic-release skips private packages, so this is the whole gate.

The package stays in the workspace: it builds, its conformance and engine suites still run in CI, and --target node remains selectable for codegen. The only thing that changes is that npm cannot receive it yet.

Follow-up

#328 completes the host and flips both settings back, so the package becomes publishable in the same change that makes it worth publishing.

Verification

lint:package-json clean (key order — private sits directly after version). check-agents-md-packages and check-sibling-peer-ranges pass. No lockfile change: the drift that showed up while working on this is pre-existing and unrelated (see the follow-up PR's notes).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated package configuration to mark the package as private.
    • Removed the package’s automated release configuration.

`@lunora/platform-node` landed as a spike (plan 234) but was configured
to publish: `.releaserc.json` present, `publishConfig.access: public`,
version `0.0.0`, never released. The next `multi-semantic-release` run
from this branch would have shipped a half-finished host to npm as
`1.0.0-alpha.1` — durable-looking alarms nothing re-arms, a scheduler
that stores jobs and never dispatches them, and no deploy driver.

Marks it `private` and drops its `.releaserc.json`, matching how
`@lunora/search-core` and `@lunora/dispatch` are kept unpublished — both
carry the same pair and both 404 on npm. `multi-semantic-release` skips
private packages, so this is the whole gate.

The package stays in the workspace: it builds, its conformance and engine
suites run in CI, and `--target node` remains selectable for codegen. The
only thing that changes is that npm cannot receive it yet. The branch
completing the host flips both back.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@netlify

netlify Bot commented Aug 2, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for lunorash ready!

Name Link
🔨 Latest commit ef6c3f3
🔍 Latest deploy log https://app.netlify.com/projects/lunorash/deploys/6a6f30441bc39e0008a14f1c
😎 Deploy Preview https://deploy-preview-327--lunorash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for confirming the Contributor License Agreement! 🙏

@coderabbitai

coderabbitai Bot commented Aug 2, 2026 •

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The platform-node package is now private. Its .releaserc.json release configuration file was removed.

Changes

Platform Node publication

Layer / File(s) Summary
Private package configuration
packages/platform-node/package.json, packages/platform-node/.releaserc.json
packages/platform-node/package.json now sets private to prevent publication. The .releaserc.json file was removed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states that the platform-node spike remains unpublished until completion.
Description check ✅ Passed The description clearly explains the reason, implementation, follow-up, and verification for keeping the package unpublished.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/platform-node-private

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@prisis
prisis merged commit 7754661 into alpha Aug 2, 2026
9 checks passed
@prisis
prisis deleted the fix/platform-node-private branch August 2, 2026 11:55
@codspeed

codspeed Bot commented Aug 2, 2026

Copy link
Copy Markdown

This PR has no benchmarks

⚠️ No benchmarks were detected in both the base of the PR and the PR.
Please ensure that your benchmarks are correctly instrumented with CodSpeed.

Check out the benchmarks creation guide


Comparing fix/platform-node-private (ef6c3f3) with alpha (07d4582)

Open in CodSpeed

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 8, 2026

This branch was previously deployed

1 inactive deployment
benchmarks — ef6c3f30 Deployed Aug 2, 2026 by prisis via Benchmarks #1376
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant