Skip to content

fix(plans): restore prettier formatting in the plan index - #367

Merged
prisis merged 2 commits into
alphafrom
fix/plans-readme-prettier
Aug 8, 2026
Merged

prisis merged 2 commits into
alphafrom
fix/plans-readme-prettier

Conversation

@prisis

@prisis prisis commented Aug 8, 2026

Copy link
Copy Markdown
Member

What

plans/README.md on alpha fails prettier --check, which is a required lint job. Because CI checks refs/pull/N/merge, every open PR fails Lint (prettier) on it — #364 and #365 are both red for a file neither of them touches.

This restores the formatting (53 lines, all table column padding) and carries one content line that missed the #366 squash: the plan 265 row now records the encoding decision that landed in #365.

How it happened, since the mechanism is reusable

#366 rewrote 24 table rows with ragged column widths and left it to Prettier to normalise. The verification ran

cd <repo-root> && pnpm exec prettier --check .worktrees/plans-readme/plans/README.md

from the main checkout, against a path under .worktrees/. Prettier ignores that path, so it matched zero files and printed All matched files use Prettier code style! — a pass that proved nothing. Running the same command inside the worktree reports the file dirty immediately.

Worth knowing when working out of a git worktree: a repo-root tool invoked on a .worktrees/** path may silently no-op instead of failing, and a green result is not evidence the file was examined. Run repo tooling from inside the worktree.

Verification

pnpm exec prettier --check plans/README.md from inside the worktree → All matched files use Prettier code style!, with the file actually matched this time. Docs only.

🤖 Generated with Claude Code

https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP

prisis and others added 2 commits August 8, 2026 15:34
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
The table-row rewrites in #366 left the column padding ragged, and the
check that should have caught it was run from the main checkout against
a path under .worktrees/, which prettier ignores — so it checked zero
files and reported success.

prettier --check . is a required lint job, and CI runs it against
refs/pull/N/merge, so this failed every open PR rather than just the one
that introduced it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
@netlify

netlify Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for lunorash ready!

Name Link
🔨 Latest commit c9c9937
🔍 Latest deploy log https://app.netlify.com/projects/lunorash/deploys/6a773088453f9f0008388b53
😎 Deploy Preview https://deploy-preview-367--lunorash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • plans/README.md is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0adc5fb5-9c4e-4b48-9205-ae29a602f04c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for confirming the Contributor License Agreement! 🙏

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@prisis
prisis merged commit a3e100f into alpha Aug 8, 2026
30 checks passed
@prisis
prisis deleted the fix/plans-readme-prettier branch August 8, 2026 13:54
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant