Repository navigation
fix(plans): restore prettier formatting in the plan index - #367
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
The table-row rewrites in #366 left the column padding ragged, and the check that should have caught it was run from the main checkout against a path under .worktrees/, which prettier ignores — so it checked zero files and reported success. prettier --check . is a required lint job, and CI runs it against refs/pull/N/merge, so this failed every open PR rather than just the one that introduced it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
✅ Deploy Preview for lunorash ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for confirming the Contributor License Agreement! 🙏 |
|
Thank you for following the naming conventions! 🙏 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What
plans/README.mdonalphafailsprettier --check, which is a required lint job. Because CI checksrefs/pull/N/merge, every open PR failsLint (prettier)on it — #364 and #365 are both red for a file neither of them touches.This restores the formatting (53 lines, all table column padding) and carries one content line that missed the #366 squash: the plan 265 row now records the encoding decision that landed in #365.
How it happened, since the mechanism is reusable
#366 rewrote 24 table rows with ragged column widths and left it to Prettier to normalise. The verification ran
from the main checkout, against a path under
.worktrees/. Prettier ignores that path, so it matched zero files and printedAll matched files use Prettier code style!— a pass that proved nothing. Running the same command inside the worktree reports the file dirty immediately.Worth knowing when working out of a git worktree: a repo-root tool invoked on a
.worktrees/**path may silently no-op instead of failing, and a green result is not evidence the file was examined. Run repo tooling from inside the worktree.Verification
pnpm exec prettier --check plans/README.mdfrom inside the worktree →All matched files use Prettier code style!, with the file actually matched this time. Docs only.🤖 Generated with Claude Code
https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP