Repository navigation
refactor(shard-engine): drop the duplicated json path quoter - #372
Conversation
Both PRs landed, so alpha carried two copies of the same escaping rule - the local one in the backfill and the shared helper. They were made byte-identical before merge precisely so this deletion would be a no-op refactor rather than a behaviour change. The local docblock also claimed documentPath does not quote at all, which stopped being true when the shared helper landed there. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
|
Warning Review limit reached
Next review available in: 18 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for confirming the Contributor License Agreement! 🙏 |
|
Thank you for following the naming conventions! 🙏 |
✅ Deploy Preview for lunorash ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #372 +/- ##
========================================
Coverage ? 85.70%
========================================
Files ? 843
Lines ? 50706
Branches ? 12365
========================================
Hits ? 43460
Misses ? 6832
Partials ? 414
🚀 New features to boost your workflow:
|
Merging this PR will regress 1 benchmark
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | count, no attributes |
60.3 µs | 67.1 µs | -10.14% |
| ⚡ | indexed: groupBy(projectId) — count (read every counter row) |
831.3 µs | 421.2 µs | +97.36% |
| ⚡ | 1 after-insert no-op trigger |
483.5 µs | 425.8 µs | +13.55% |
| ⚡ | flat 3 primitives (the notify.send attribute shape) |
62.5 µs | 55.5 µs | +12.46% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing fix/dedupe-json-path-segment (f743ff0) with alpha (4361cbc)2
Footnotes
-
109 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
alpha(c2f07b3) during the generation of this report, so 4361cbc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What
#365 and #371 both landed, so
alphanow carries two copies of the same JSON-path escaping rule: the localjsonPathSegmentinreprojection-backfill.tsand the sharedshared/json-path-segment.ts. This deletes the local one.Both PR bodies flagged this as the merge-order follow-through, and the two implementations were deliberately made byte-identical before either merged — verified by extracting and diffing the function bodies — so this is a no-op refactor rather than a behaviour change. Net −44 lines.
It also removes a comment that stopped being true
The local docblock carried:
That was accurate when written. #371 made
documentPathquote (do-sql.ts:182), so it is now false. Deleting the duplicate takes the stale claim with it — which matters here, because a comment asserting a property the code does not have is the exact defect class this whole line of work kept turning up.Verification
@lunora/shard-engine67 files / 1040 passed,lint:eslint --max-warnings=0exit 0,lint:typesclean, Prettier clean,api:check✅ 47 snapshots unchanged (the helper was never on the public surface — it was exported from the module for its own test only, and the test now imports the shared one directly).Two process notes, since both cost a cycle here and are worth knowing:
pnpm exec eslint <path>from the repo root resolves the roottsconfig.json, whoseincludeis[], and fails withTS18003: No inputs were found— which looks like a code error and is not. The package script (eslint ., cwd = package) is the one that reports real findings.build:packagesfails every test file, not just the changed ones.🤖 Generated with Claude Code
https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP