Repository navigation
docs(plans): retire 265 and 302 - #373
Conversation
Both shipped, so their files go and the README rows become the record - the convention this directory states in its own header, and the one that had rotted badly enough that a whole wave still read TODO months after merging. The rows keep what a reader would otherwise have to reconstruct from git: for 265, the four attempts, why the exact-int64 alternative is a trap, and that the backfill shipped with it; for 302, that the merge-order dependency actually fired and turned alpha red, and that the plan's error counts were measured on a cold tree. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
✅ Deploy Preview for lunorash ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (3)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for following the naming conventions! 🙏 |
|
Thank you for confirming the Contributor License Agreement! 🙏 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What
265 and 302 both shipped, so their plan files go and the README rows become the record — the rule this directory states in its own header:
Net −792 lines. Nothing else changes.
Why the rows got longer while the files went away
That convention had rotted: the entire Wave 13 table read
TODOfor work squash-merged months earlier, and plan 265's row readBLOCKED — DO NOT MERGEwhen it had in fact shipped broken. Retirement only stays honest if it happens at merge time, so these two are retired now, with the rows carrying what a reader would otherwise have to reconstruct from git.265 — four attempts, and the sequence is the useful part:
ab0afaf00madev.bigint()storable and thereby unqueryable; aNumber()projection then returned rows that were not equal above 2^53 and made auniqueindex reject two distinct bigints (false positives replacing false negatives); a reserved key silently destroyed a user field of the same name. What shipped is a fixed-width sign-aware order-preserving decimal key, proven by a property test over ~44.5k pairs in JS and again under real SQLiteORDER BY. The row also records the trap someone will otherwise retry: SQLite genuinely holds exact int64 throughjson_extract, but reading such a row back throwsRangeErrorout of the driver, so the row becomes unreadable — verifying storage without verifying the read makes that option look correct.302 — the merge-order dependency fired: #363 made
svelteclean while #364's allowlist still named it, and the guard fails on a stale entry by design, soalphawent red until #368 emptied the map. Also recorded: the real error counts were 38/117/303/24, not the plan's, because the plan measured on a cold tree where missing dependencydist/inflates figures roughly 4–12×.Also
Verification
Cross-checked programmatically rather than by eye: every file in
plans/appears in the list, and every plan the list names as present has a file. The five it names as retired (235, 248, 311, 265, 302) are correctly absent. No dangling links to either removed file anywhere in the repo. Prettier clean. Docs only.🤖 Generated with Claude Code
https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP