Repository navigation
docs(plans): file 313, the object-storage backup tier - #384
Conversation
lunora backup already has both tiers and names them: pitr covers the last 30 days in place, and create/restore is the portable one for everything older. The second writes through node:fs to a local dir, so the tier that exists for the case the 30-day window cannot cover depends on whichever disk the CLI ran on, automated by an external cron. The snapshot format, manifest, export/import endpoints and R2 bindings all exist, so this is a destination rather than a redesign. Acceptance is a bigint and bytes round-trip, which is what plan 265 showed the export path could silently lose. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
Phases 0-1 and WS5 shipped in #375. WS4 did not: retention still deletes inside every cron run, narrowed by a cron-expression marker rather than made explicit, which is not what §4.4 promised. That gap is also where the branch's worst defect came from - unifying the key layout is what makes list --bucket one history and what made the two writers indistinguishable to the existing prune. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
✅ Deploy Preview for lunorash ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for following the naming conventions! 🙏 |
|
Thank you for confirming the Contributor License Agreement! 🙏 |
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Files plan 313, the plan #375 implements, plus its execution record.
The finding
lunora backupalready had two tiers and named them in its own docblock:pitrdrives the platform's DO change log for the last 30 days in place, andcreate/restoreis the off-platform, portable, >30-day tier. But that second tier wrote NDJSON throughnode:fs/promisesto--dir, so the durability of the tier that exists for exactly the case the 30-day window cannot cover was whatever disk the CLI ran on — automated, per its own docs, by an external cron.So the fix was a destination, not a format: the snapshot, manifest, export/import endpoints and R2 bindings all existed.
§10 — the execution record, and one deviation
Phases 0–1 shipped as designed. WS5 shipped too, outside its phasing, because reviewing both writers side by side surfaced that the scheduled backup recorded no checksum —
restore --verifyrefused precisely the snapshots nobody watches being taken.WS4 did not ship, and §4.4 said it would. The plan promised "Retention is explicit, not clever … No silent deletion of anything" and a
pruneverb. What shipped keepsbackupRetaindeleting inside every cron run; the review-added writer check makes that narrower, not explicit. It is safe now — retention matches on the cron expression via object custom metadata read off the listing, so two deployments sharing a prefix keep the retention each configured — but it is not what the plan promised, and §10 says so rather than quietly reinterpreting the plan to match the code.That gap is also where the branch's worst defect came from: unifying the key layout is what makes
list --bucketone history and what made the two writers indistinguishable to the existing prune. The feature and the bug were the same decision.The pattern worth carrying forward
Three thermo rounds, each finding something the previous declared clean, and every defect in the remediation rather than the original work. The recurring shape was not stale comments — it was a claim about a second party's behaviour that was never checked against the second party: a guard documented as preventing an OOM it could not prevent (the export fan-out resolves every shard's rows before the first byte is encoded); an upload documented as checksum-verified above the size where the verified route stops being used; remediation text telling an operator to pass
createStorage(...).downloadwhere the signatures share no properties and the assignment does not compile.Docs only.
🤖 Generated with Claude Code
https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP