Skip to content

docs(plans): retire 313 - #390

Merged
prisis merged 2 commits into
alphafrom
docs/retire-plan-313
Aug 9, 2026
Merged

prisis merged 2 commits into
alphafrom
docs/retire-plan-313

Conversation

@prisis

@prisis prisis commented Aug 9, 2026

Copy link
Copy Markdown
Member

Plan 313 is complete, so its file goes and the README row becomes the record — the rule this directory states in its own header. −216 lines.

What shipped

#375 made object storage a destination for the portable backup tier: a BackupDestination seam with filesystem and R2 implementations, restore --verify, and an admin read route so a bucket restore does not depend on URL signing.

#389 closed WS4, which is the part that made the plan's own decision true rather than nominally satisfied: the scheduled backup no longer deletes at all. lunora backup prune is the only thing in Lunora that removes a backup, lunora backup retention previews what it would take, and the cron reports what sits past the window instead of quietly removing it. One selectStaleBackups feeds all three consumers, so a prediction cannot disagree with a deletion.

Verified on alpha before retiring the file — in a squash repo the PR state cannot tell you this: the preview route, both log records, both CLI verbs, and pruneBackups reachable only from runBackupPrune while the scheduled path calls selectStaleBackups and stops.

Why the row is long

Six review rounds, and the useful record is not the fix list — it is that every defect after the first round was in the remediation rather than the original work, and they shared one shape: a claim about a second party's behaviour that was never checked against the second party.

  • A guard documented in six places as preventing an OOM it could not prevent, because the export fan-out resolves every shard's rows before the first byte is encoded.
  • An upload documented as checksum-verified above the size where the verified route stops being used.
  • Remediation text telling an operator to pass a function whose signatures share no properties — it did not compile, and after being fixed to compile it silently discarded the bucket.
  • A prune whose confirmation was not binding, because the POST carried no selection and the server re-selected: a snapshot displayed as kept could be deleted by a cron fire landing inside the confirmation window.

Nine such comments in all. That is a more useful thing to carry forward than any individual fix, so it lives in the row rather than only in git history.

Verification

Cross-checked programmatically: every file in plans/ appears in the remaining-files list, and no reference to 313-r2-backup-tier.md survives anywhere in the repo. Prettier clean. Docs only.

🤖 Generated with Claude Code

https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP

Both halves shipped - the object-storage destination in #375, and in
#389 the part that made the plan's own decision true: the scheduled
backup no longer deletes, prune is the only thing that removes a
backup, and retention previews what it would take.

The row keeps what git alone would not tell you. Six review rounds, and
every defect after the first was in the remediation rather than the
original work, all of one shape - a claim about a second party's
behaviour never checked against the second party.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
@netlify

netlify Bot commented Aug 9, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for lunorash ready!

Name Link
🔨 Latest commit 8b495cc
🔍 Latest deploy log https://app.netlify.com/projects/lunorash/deploys/6a78b2216834390008de834f
😎 Deploy Preview https://deploy-preview-390--lunorash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • plans/313-r2-backup-tier.md is excluded by none and included by none
  • plans/README.md is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6808586f-9e8a-4ac3-8fc1-76fdebaca67c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Thank you for confirming the Contributor License Agreement! 🙏

@prisis
prisis merged commit ae20bf1 into alpha Aug 9, 2026
12 of 13 checks passed
@prisis
prisis deleted the docs/retire-plan-313 branch August 9, 2026 17:00
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant