fix(tui): deduplicate plugin targets - #49112
Merged
Merged
Conversation
kitlangton
enabled auto-merge (squash)
September 15, 2026 15:39
kitlangton
force-pushed
the
dedupe-tui-targets
branch
from
September 15, 2026 23:42
69a093c to
25d2034
Compare
kitlangton
force-pushed
the
dedupe-tui-targets
branch
from
September 16, 2026 00:54
25d2034 to
7c4eb77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A combined plugin can reach the TUI through both local-directory discovery and the server plugin inventory. When loading fails, both equivalent targets were resolved independently and displayed as duplicate failure rows, making one failure look like two plugins.
What Changes
Targets are canonicalized with the existing local source resolver before plugin loading. Deduplication retains the final target definition so explicit configuration keeps precedence over discovered and server-provided defaults.
Demo
The recordings use the same isolated combined plugin fixture. Its TUI entrypoint intentionally throws
Fixture plugin failed.Before: one failed target appears twice.
dedupe-before.mp4
After: the equivalent sources produce one failed target.
dedupe-after.mp4
OpenCode Drive 2.1.0 could not launch current V2 for this capture because of opencode-drive#87. These matched recordings use a real PTY via Terminal Control instead.
Scope
This PR deduplicates TUI plugin resolution targets only. It does not change server plugin inventory or successful plugin registration by plugin ID.
Verification
The complete TUI suite also ran: 1,076 passed and 5 existing environment-sensitive lifecycle tests failed because they discovered the globally installed personal
kit.codex-limits.tuiplugin inside fixtures.