fix(app): limit export filename length - #49143
Open
sdivyanshu90 wants to merge 1 commit into
Open
sdivyanshu90 wants to merge 1 commit into
sdivyanshu90 wants to merge 1 commit into
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: The search found a related PR that should be reviewed: Related PR:
This PR (#49138) also addresses export filename handling in the app, and was filed just before this one (#49143). While not an exact duplicate, these are closely related fixes to the export filename generation logic and should be reviewed together to ensure they don't conflict or duplicate effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #49142
Type of change
What does this PR do?
Caps the sanitized session title or slug at 250 ASCII characters before adding
.json, keeping generated export filenames within a 255-byte component limit. Existing short filenames and the session-ID fallback remain unchanged.How did you verify your code works?
Reproduced
ENAMETOOLONGwith the previous 305-byte result, added a regression test for a 300-character title, and ran the focused session-export test frompackages/app: 6 tests passed with 7 assertions.Screenshots / recordings
Not applicable; this is a non-UI filename-generation fix.
Checklist