Conversation
Without this change, --baseline still built both the regular and baseline x64 targets on macOS. On non-AVX Intel Macs (Westmere, X5690), the regular bun-darwin-x64 target uses AVX2 and crashes with SIGILL. Now --single --baseline produces only the baseline binary as intended.
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search results, I found one potentially related PR: Related PR:
The current PR (49145) is distinct because it focuses on fixing the |
github-actions
Bot
removed
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #49150
Type of change
What does this PR do?
On non-AVX Intel Macs (Westmere, Xeon X5690), the official bun-darwin-x64 runtime contains AVX2 instructions and crashes with SIGILL. The build script's --baseline flag was not working correctly: it still built both the regular and baseline x64 targets, causing the build to fail or produce an incompatible binary.
This change makes --single --baseline select only the baseline target instead of also building a regular x64 target. This allows the build to succeed with the patched non-AVX Bun binary.
How did you verify your code works?
Built successfully on the target machine (Intel Xeon X5690, x86_64, SSE4.2, no AVX/AVX2) with version 1.18.31. Used a patched Bun build with -march=nehalem.
Checklist