Conversation
The review panel caches its vcs.diff query with every refetch hook disabled, so it only refreshes through explicit invalidation. Most terminal git operations still refresh it by accident because they rewrite workspace files, but a git commit/add/amend only rewrites files under .git, which produced no event: - the server's .git subscription watches only HEAD, and a regular commit does not change HEAD's content - the client's session VCS listener dropped every .git path anyway (that check also compared a relative prefix against absolute event paths, so it never actually matched) The panel then kept showing pre-commit changes until an unrelated event happened to refresh it. - watch .git/index alongside HEAD in the core watcher (staging and commits rewrite it; everything else under .git stays ignored) - in the session VCS listener, treat paths under .git whose basename is index or HEAD as VCS state changes and call the existing debounced refreshVcs(); basename matching also covers git worktrees, where the path is .git/worktrees/<name>/index - flip the watcher test to assert .git/index events are published and add coverage that other .git files remain ignored Co-Authored-By: Claude Code <noreply@anthropic.com>
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review panel caches its vcs.diff query with every refetch hook disabled, so it only refreshes through explicit invalidation. Most terminal git operations still refresh it by accident because they rewrite workspace files, but a git commit/add/amend only rewrites files under .git, which produced no event:
The panel then kept showing pre-commit changes until an unrelated event happened to refresh it.
Issue for this PR
Closes #
Type of change
What does this PR do?
Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR.
If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.