Conversation
Pressing Enter or Escape to confirm/cancel IME composition (e.g. Japanese kana-kanji conversion) in the question dock's custom answer textarea was treated as commit/dismiss, moving focus out of the input to the option card. Guard key handlers with the same isImeComposing pattern used in prompt-input.tsx. Fixes anomalyco#49154
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49154.
In the Desktop question dock (
SessionQuestionDock), the custom answertextareatreated everyEnter/Escapekeydown as commit/dismiss — including the keystrokes used to confirm or cancel IME composition (e.g. Japanese kana-kanji conversion with Google Japanese Input). As a result, confirming a conversion moved focus out of the input to the option card, interrupting continuous Japanese input.This mirrors the existing
isImeComposingpattern fromcomponents/prompt-input.tsx(event.isComposing || composing() || event.keyCode === 229, with explicit composition tracking for platforms wherecompositionendfires before the confirmingEnter):textarea onKeyDown: return early while IME is composing, before theEscape/Enterhandling.onCompositionStart/onCompositionEnd.nav(DockPrompt-level keydown): don'treject()onEscapeor advance onCmd/Ctrl+Enterwhile IME is composing (keydowns bubble up from the textarea).Verified against the screen recording attached to #49154 (focus leaving the inner textbox for the outer option card after conversion confirm). I could not run the full app typecheck in this environment (sparse checkout, no installed workspace deps); the change follows the exact pattern already used in
prompt-input.tsx.