Conversation
Pressing Enter or Escape to confirm/cancel IME composition (e.g. Japanese kana-kanji conversion) in the question dock's custom answer textarea was treated as commit/dismiss, moving focus out of the input to the option card. Guard key handlers with the same isImeComposing pattern used in prompt-input.tsx. Fixes anomalyco#49154
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
The following comment was made by an LLM, it may be inaccurate: I found one potentially related PR: PR #44826: fix(prompt-input): keep the editor inert during IME composition This PR is related because it also addresses IME composition handling in the |
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
Issue for this PR
Closes #49154
Type of change
What does this PR do?
In the Desktop question dock (
SessionQuestionDock), the custom answertextareatreatedEnter/Escapepressed to confirm or cancel IME composition (e.g. Japanese kana-kanji conversion) as commit/dismiss, moving focus out to the option card.Applies the same
isImeComposingpattern used incomponents/prompt-input.tsx(event.isComposing || composing() || event.keyCode === 229):textarea onKeyDown: early return while IME is composing, beforeEscape/EnterhandlingonCompositionStart/onCompositionEndnav(DockPrompt-level keydown): skipreject()onEscapeandnext()onCmd/Ctrl+Enterwhile IME is composingHow did you verify your code works?
Checked against the screen recording in #49154 (focus leaving the inner textbox for the outer option card after conversion confirm). Full app typecheck not run in this environment (sparse checkout, no installed workspace deps); the change follows the existing pattern in
prompt-input.tsx.Screenshots / recordings
See the recording attached to #49154. No new recording attached.
Checklist