Skip to content

fix(core): fail fast when DB schema is ahead of current runtime #49225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MdTanwer wants to merge 1 commit into
base: dev
Choose a base branch
from
+14 −0
Open

fix(core): fail fast when DB schema is ahead of current runtime #49225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/core/src/database/migration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,20 @@ export function applyOnly(db: Database, input: Migration[]) {
}
}

// Guard: if the DB's migration table contains IDs this binary has never heard
// of, the schema was advanced by a newer runtime. Fail fast here rather than
// silently opening an incompatible database and crashing deep inside a query.
const knownIds = new Set(input.map((m) => m.id))
const unknownAhead = [...completed].filter((id) => !knownIds.has(id))
if (unknownAhead.length > 0)
return yield* Effect.die(
new Error(
`Database schema is newer than this OpenCode runtime. ` +
`Unknown migration(s): ${unknownAhead.join(", ")}. ` +
`Upgrade your CLI or Desktop to match, or set OPENCODE_DB to use a separate database file.`,
),
)

for (const migration of input) {
if (completed.has(migration.id)) continue
yield* db.transaction((tx) =>
Expand Down
Loading