test: align tui and cli fixtures with interactive resource refactor - #49248
Closed
rekram1-node wants to merge 2 commits into
Closed
rekram1-node wants to merge 2 commits into
rekram1-node wants to merge 2 commits into
Conversation
12e53ee moved form.list under session.form and updated the fixture but left one assertion on the old path, so the replacement test failed.
…ELETE 12e53ee renamed the permission reply body field to decision and moved form cancellation to DELETE /api/session/{id}/form/{formID}, but the ACP SSE fixture still read reply and only routed the old POST path.
rekram1-node
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
12e53ee6d4(refactor(protocol): simplify interactive resources) changed several client surfaces and updated production code, but left test fixtures on the old shapes. TheunitCI job fails on the currentv2tip for any PR based on it (for example #49241);v2's own runs were green only because turbo skipped the untouched packages.Two fixture updates, no runtime code changes:
packages/tui—client.form.listmoved toclient.session.form.list. The mock was updated but one assertion intest/mini/stream-v2.transport.test.tsstill spied onsecond.form.list.packages/cli— the permission reply body field was renamedreply→decision, and form cancellation moved fromPOST …/form/{id}/canceltoDELETE …/form/{id}.test/acp/sse-fixture.tsstill readreply(so every reply returned 400) and only routed the old cancel path (so the DELETE 404'd).permission-behavior.test.tsalso readbody.reply.How did you verify your code works?
bun test test/mini/stream-v2.transport.test.tsinpackages/tui: 67/67 (was 66/67).bun test test/acpinpackages/cli: 94/94 (was 85/94); fullpackages/clisuite 261/261.bun x prettier --checkclean on the edited cli files.Checklist