Conversation
When a thinking block is open while a patch tool runs, the timeline showed a spinner on the thinking header and a second one on the patch row. Absorb the running patch into the thinking line ("Thinking · Patch <target>") and hide the duplicate patch row, reappearing as usual once either side settles.
Fixes anomalyco#44164
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #44164
Type of change
What does this PR do?
When a thinking block is open and a patch tool is running in the same message, the timeline drew two live lines: the thinking header spinner plus the patch row spinner.
While both are active they now merge into one line — the thinking header reads
Thinking · Patch <target>and the running patch row is hidden. The row comes back as soon as either side settles (thinking completed, or patch finished/failed), so completed states are unchanged. Both layouts are covered: the expanded reasoning block and the collapsed thinking row.How did you verify your code works?
Ran the tui suite locally: 1334 pass, 4 failures that are plugin-reload / dialog-shell-output flakes failing the same way on the base commit (checked by stashing the change).
typecheckclean for packages/tui.Screenshots / recordings
Not applicable — terminal rendering change, no stable screenshot.
Checklist
Supersedes #49163 — identical commit (
a95453128b), closed earlier because the description was missing the template sections.