feat(tui): open execute call details dialog on click - #49259
Merged
Merged
Conversation
line_number right-aligns digits in a gutter sized to that block alone, so the column "1" starts on changes with the line count and differs between calls. Draw one left-aligned gutter for both blocks instead.
Drop the prop-forwarding wrapper. Parse code and output from the tool state into string | undefined and a highlighted JSON result, and narrow those in Show instead of sentinel empty strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking the
executetool row in the V2 TUI session view now opens a dialog with the program's source and its output. All existing row behavior is unchanged: the child tool-call list, click-to-expand on each child call, the inline error preview, and click-to-toggle on tool-level errors.Dialog (
packages/tui/src/routes/session/dialog-execute.tsx)Receiving code…/Running/Completed · 2.2s/Failed · 187ms)jsonparser and numbered; its gutter is aligned with the code gutter so both blocks start on the same column. TrailingWarnings:/Logs:sections stay plain text; error output is rendered in the error color←/→pans long lines. Fits its content up to ~70% of the terminal height, then scrolls (↑/↓,pgup/pgdn,home/end)ccopies the code,ocopies the outputRefactor
ExecuteCall,executeCalls,executeCallSummarymoved fromroutes/session/index.tsxtoutil/tool-display.ts;executeCallSummaryis still re-exported from the session route for the existing test.Screenshots
Testing
bun run lintandbun typecheck(packages/tui) passbun test test/cli/tui/inline-tool-wrap-snapshot.test.tsxpasses (coversexecuteCallSummary)bun run dev:live: open via click, child-call expand still works, copy shortcuts,esc, narrow (80 col) and wide (140 col) layouts, success and failed calls, wrapped-code height fitting