Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #40839
Type of change
What does this PR do?
AppImage sets
ARGV0to its executable path. When inherited by zsh, it overrides child commands'argv[0], causing Rustup proxies such ascargoandrustcto fail withunknown proxy namein the integrated terminal.ARGV0from the PTY environment before spawning the shell.ARGV0is removed while preserving terminal variables and the parent process environment.How did you verify your code works?
--appimage-extract-and-run. Through the bundled backend's PTY API, verified thatcargo --version,rustc --version, and an offline Rust program fail before the fix and succeed after it.git diff --check.Screenshots / recordings
Rendered from captured AppImage PTY output; command labels added and long valid-proxy lists omitted.
Checklist