Skip to content

refactor(core): list which extension calls show under execute - #49281

Merged
rekram1-node merged 1 commit into
v2from
extension-display
Sep 16, 2026
Merged

rekram1-node merged 1 commit into
v2from
extension-display

Conversation

@rekram1-node

Copy link
Copy Markdown
Collaborator

Extension calls only get a row under execute when they are listed. Today that list is fetch; the filesystem extension will add its entries here, and helpers like path.join will stay off the list.

 progressHooks  packages/core/src/codemode/tool.ts
-    "extension.before": (call) =>
-      start(call, { tool: call.name, status: "running", ...(call.name === "fetch" ? { input: display(call.args) } : {}) }),
+    "extension.before": (call) => {
+      switch (call.name) {
+        case "fetch":
+          return start(call, { tool: call.name, status: "running", input: CodeModeWeb.display(call.args) })
+        default:
+          return Effect.void
+      }
+    },

settle now returns Effect.void when a call has no row instead of re-recording the unchanged list, so unlisted calls emit no progress at all.

Verified against a local server: a fetch row still appears as running and settles to completed. bun run check 35/35; packages/core test/tool-execute.test.ts + test/codemode 27 pass.

@rekram1-node
rekram1-node merged commit 9add938 into v2 Sep 16, 2026
10 checks passed
@rekram1-node
rekram1-node deleted the extension-display branch September 16, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant