Skip to content

feat(knowledge): add governed engineering memory and MCP capabilities - #49297

Closed
salfd77 wants to merge 8 commits into
anomalyco:devfrom
salfd77:feat/engineering-memory-v1
Closed

feat(knowledge): add governed engineering memory and MCP capabilities#49297
salfd77 wants to merge 8 commits into
anomalyco:devfrom
salfd77:feat/engineering-memory-v1

Conversation

@salfd77

@salfd77 salfd77 commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Issue for this PR

No linked issue. This PR introduces the governed Engineering Memory capability described below.

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Adds a local Engineering Memory system with explicit staging, review, approval, admission, retrieval, and status operations.

The PR also:

  • adds optional first-turn knowledge retrieval behind an experimental flag
  • keeps approval and admission as separate operations
  • prevents import-time database creation
  • resolves packaged database paths outside the Bun embedded filesystem
  • exposes direct MCP tools when codemode is disabled
  • configures and verifies Playwright and Context7 MCP integrations
  • adds AI engineering and prompt engineering project skills
  • preserves Effect layer identity when dependencies are unchanged

How did you verify this change?

  • Knowledge Engine tests: 80 passed
  • Learn Memory tests: 29 passed
  • Core layer-node tests: 21 passed
  • MCP direct-tool regression test: 1 passed
  • Typecheck passed for knowledge-engine, core, and opencode
  • Packaged binary verified with --version, session list, and search
  • Playwright MCP verified with navigation and snapshot tool calls
  • Context7 MCP verified with library resolution and documentation retrieval
  • Rebased successfully onto the latest origin/dev
  • Working tree remained clean after verification

Checklist

  • I tested the changes locally
  • I added or updated tests where appropriate
  • I confirmed there are no unrelated changes
  • I confirmed no local databases, build outputs, or Playwright run artifacts are tracked
  • I reviewed the full branch diff against origin/dev
  • I documented known limitations in BRANCH_BEHAVIOR_REVIEW.md

Known limitations

  • First-turn retrieval has no live latency benchmark yet
  • Batch proposal writes are not wrapped in one cross-row transaction
  • Empty-corpus search currently uses the general no-results message
  • Removed eager singleton exports may affect undiscoverable external consumers

AH added 8 commits September 16, 2026 00:15
AH
feat(knowledge): add governed engineering memory system
e639297
AH
feat(core): integrate first-turn knowledge retrieval into v2 runtime
a3ed3e2
AH
feat(cli): add governed memory review and admission commands
31157f4
AH
chore(git): ignore local knowledge database artifacts
b1cd213
AH
feat(opencode): enable direct MCP tools and expert skills
1423089 
- support codemode in local and remote MCP configuration
- preserve codemode through V2 compatibility conversion
- expose direct MCP tools through the tool registry
- configure Playwright and Context7 integrations
- add regression coverage for direct MCP tool projection
- add AI engineering and prompt engineering skills
- ignore local Playwright runtime artifacts
- document verified MCP capability status
AH
fix(core): preserve layer identity when dependencies are unchanged
2abe704 
- merge direct dependencies explicitly before providing the layer
- preserve node identity when dependency rewrites make no changes
- rebuild nodes only when a dependency is actually replaced
- replace behavior-pinning cases with dependency contract tests
AH
fix(knowledge): resolve packaged database paths lazily
8e2f502 
- resolve packaged database files under the stable user data directory
- preserve explicit path and environment overrides
- create parent directories only when a store is opened
- remove import-time database initialization
- keep version and session commands free of knowledge database effects
- add packaged-path and lazy-initialization regression tests
AH
docs(knowledge): record engineering memory behavior review
f69c531
@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@salfd77

salfd77 commented Sep 16, 2026

Copy link
Copy Markdown
Author

Closing this pull request because this branch belongs to a separately maintained fork and was submitted upstream by mistake. No action is required from the maintainers. Thank you.

@salfd77 salfd77 closed this Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs:compliance This means the issue will auto-close after 2 hours.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@salfd77