Conversation
Empty string apiKey must not enable a provider or suppress Auth.none. Fixes anomalyco#42790.
Author
Shepherd noteTip
Happy to help land once checks are unblocked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #42790
Type of change
What does this PR do?
Empty
apiKey: ""was treated as a real credential string — catalog marked credentialless providers available, then auth apply used Auth.value("") instead of Auth.none (same as omitted). Treat empty as unset in catalog.available() and session runner apiKey().How did you verify your code works?
Bare
devtip (88c6c7a):typeof apiKey === "string"enables empty andAuth.value("")on apply — empty/missing suite absent / tip semantics FAIL. On this branch:3 pass. Full
catalog.test.ts+session-runner-model.test.ts: 29 pass, 0 fail.Screenshots / recordings
n/a (non-UI)
Checklist