fix(tui): handle JSON parse error on double-escape abort #7959
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate FoundPR #7939: "fix: add error handling to RPC system to prevent crashes on session abort" Why it's related: This PR addresses the same underlying issue of handling errors during session abort to prevent crashes. Both PRs target the scenario where a session abort races with in-flight requests, though PR #7939 focuses on the RPC system while PR #7959 (current) targets the TUI prompt component specifically. |
zerone0x
force-pushed
the
fix/abort-json-parse-crash
branch
from
88785d6 to
a29bca8
Compare
When aborting a session with double-escape, the abort races with the in-flight prompt request. If the response is incomplete or empty, the SDK's JSON parser throws "Unexpected end of JSON input". Adding .catch() silences this expected error during abort, matching the pattern used elsewhere for session.abort() calls. Fixes anomalyco#7946 Co-Authored-By: Claude <noreply@anthropic.com>
zerone0x
force-pushed
the
fix/abort-json-parse-crash
branch
from
a29bca8 to
dda8368
Compare
This was referenced Jan 12, 2026
Contributor
|
@zerone0x this will be handled upstream, not sure if your change is still relevant after that hey-api/openapi-ts#3202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7946
When aborting a session with double-escape (pressing Esc twice), the
session.abort()call races with the in-flightsession.prompt()request. If the server terminates the response mid-stream, the response body is incomplete or empty, causing the SDK's JSON parser to throwSyntaxError: Unexpected end of JSON input.Changes
.catch(() => {})to thesession.abort()call in the TUI prompt component to silently ignore expected errors during abortThis matches the existing pattern used in
routes/session/index.tsx:400andapp/src/pages/session.tsx:577for the same scenario.Test plan
bun run typecheckon the opencode package (passes)🤖 Generated with Claude Code